Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to change the channel order when using 4 decks #13977

Open
dmt-hub opened this issue Dec 4, 2024 · 9 comments
Open

allow to change the channel order when using 4 decks #13977

dmt-hub opened this issue Dec 4, 2024 · 9 comments

Comments

@dmt-hub
Copy link

dmt-hub commented Dec 4, 2024

Feature Description

at the moment when using 4 decks it places deck 1 & 2 in the middle of the mixer so it goes like this: 3 1 2 4 - which can be confusing.
would be great if we could have the option to have this more logical order: 1 2 3 4 in the mixer section when using 4 decks.
Screenshot 2024-12-04 at 20 22 59

@dmt-hub dmt-hub added the feature label Dec 4, 2024
@Swiftb0y
Copy link
Member

Swiftb0y commented Dec 4, 2024

Thats also a skin feature. And not a super hard one to implement at that. Take a look at our Skin documentation: https://github.com/mixxxdj/mixxx/wiki#skin-documentation I'm sure you'd be able to hack this feature together yourself.

@ronso0
Copy link
Member

ronso0 commented Dec 4, 2024

Yes, most of it is just how the decks are arranged in skins, but note that 3-1-2-4 is also assumed in some places of the engine, for example for the default crossfader assignments (1, 3 left | 2,4 right).
Though this can also be set in the skin's <attributes> section IINM.

@daschuer
Copy link
Member

daschuer commented Dec 5, 2024

@dmt-hub
Copy link
Author

dmt-hub commented Dec 5, 2024

@ronso0
In which .xml file can i change these settings?

@dmt-hub
Copy link
Author

dmt-hub commented Dec 5, 2024

@Swiftb0y
In mixer_4decks.xml i changed it to:

      <Template src="skins:LateNight/mixer/channel_4decks.xml">
        <SetVariable name="ChanNum">1</SetVariable>
        <SetVariable name="xfaderLeft">default</SetVariable>
        <SetVariable name="xfaderRight">warning</SetVariable>
      </Template>

      <Template src="skins:LateNight/mixer/channel_4decks.xml">
        <SetVariable name="ChanNum">2</SetVariable>
        <SetVariable name="xfaderLeft">default</SetVariable>
        <SetVariable name="xfaderRight">warning</SetVariable>
      </Template>

      <Template src="skins:LateNight/mixer/channel_4decks.xml">
        <SetVariable name="ChanNum">3</SetVariable>
        <SetVariable name="xfaderLeft">warning</SetVariable>
        <SetVariable name="xfaderRight">default</SetVariable>
      </Template>

      <Template src="skins:LateNight/mixer/channel_4decks.xml">
        <SetVariable name="ChanNum">4</SetVariable>
        <SetVariable name="xfaderLeft">warning</SetVariable>
        <SetVariable name="xfaderRight">default</SetVariable>
      </Template>

But that doesnt seem to work, the channels stay the same

@ronso0
Copy link
Member

ronso0 commented Dec 5, 2024

Yes, these are the mixer channels.
You also need to adjust waveforms_container.xml.

the channels stay the same

Where?
In the GUI it should now be 1-2-3-4.
In case you want your controller mapping to match the GUI you need to adjust that as well.

@dmt-hub
Copy link
Author

dmt-hub commented Dec 5, 2024

@ronso0
So i made a duplicate of LateNight skin residing here: /Applications/Mixxx.app/Contents/Resources/skins/LateNight copy
changed mixer_4decks.xml & waveforms_container.xml
saved those files
reloaded the skin in mixxx
the channels are still in the same location 3 1 2 4 in the gui
the waveforms too

@dmt-hub
Copy link
Author

dmt-hub commented Dec 5, 2024

@ronso0
problem solved by renaming the folder to LateNight
Thanks for the help!

@ronso0 ronso0 changed the title FR: ability to reorder the channel order when using 4 decks allow to change the channel order when using 4 decks Dec 5, 2024
@ronso0
Copy link
Member

ronso0 commented Dec 5, 2024

We have already a WIP PR for it: #13724

This is a duplicate of #11174 https://mixxx.zulipchat.com/#narrow/channel/247619-UI-.26-UX-design/topic/4.20Deck.20Waveform.20ordering

Thanks, that's the discussion I was looking for.
Not really a duplicate because there is still no possibility to reorder the channels, so let's keep this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants