Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Qt6Dependencies.cmake is incorrect #813

Open
1 task done
DanielMcInnes opened this issue Aug 6, 2024 · 1 comment
Open
1 task done

[Bug]: Qt6Dependencies.cmake is incorrect #813

DanielMcInnes opened this issue Aug 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DanielMcInnes
Copy link

Bug description

When running the following command:
aqt install-qt linux desktop 6.6.3 wasm_singlethread -m qtwebsockets qt5compat qtshadertools --outputdir /opt/hostedtoolcache/Qt

... the installed file /opt/hostedtoolcache/Qt/6.6.3/wasm_singlethread/lib/cmake/Qt6/Qt6Dependencies.cmake differs from what gets installed by the Qt MaintenanceTool.

Likewise for /wasm_singlethread/lib/cmake/Qt6BuildInternals/QtBuildInternalsExtra.cmake

Expected behavior

aqt install-qt should install the same files that the qt MaintenanceTool does

aqt and python version

aqtinstall(aqt) v3.1.18 on Python 3.10.12 [CPython GCC 11.4.0]

Operating System

Linux/Unix

Relevant log output

dmcinnes@dmcinnes-System-Product-Name:~/git/victron/gui-v2$ diff /opt/Qt/6.6.3/wasm_singlethread/lib/cmake/Qt6/Qt6Dependencies.cmake /opt/hostedtoolcache/Qt/6.6.3/wasm_singlethread/lib/cmake/Qt6/Qt6Dependencies.cmake &
[3] 37500
dmcinnes@dmcinnes-System-Product-Name:~/git/victron/gui-v2$ 4,5c4,5
< set(__qt_platform_initial_qt_host_path "/opt/Qt/6.6.3/gcc_64")
< set(__qt_platform_initial_qt_host_path_cmake_dir "/opt/Qt/6.6.3/gcc_64/lib/cmake")
---
> set(__qt_platform_initial_qt_host_path "/Users/qt/work/install")
> set(__qt_platform_initial_qt_host_path_cmake_dir "/Users/qt/work/install/lib/cmake")




dmcinnes@dmcinnes-System-Product-Name:~/git/victron/gui-v2$ diff /opt/Qt/6.6.3/wasm_singlethread/lib/cmake/Qt6BuildInternals/QtBuildInternalsExtra.cmake /opt/hostedtoolcache/Qt/6.6.3/wasm_singlethread/lib/cmake/Qt6BuildInternals/QtBuildInternalsExtra.cmake
45,46c45,46
<     set(qtbi_orig_prefix "/opt/Qt")
<     set(qtbi_orig_staging_prefix "/opt/Qt/6.6.3/wasm_singlethread")
---
>     set(qtbi_orig_prefix "C:/Qt/Qt-6.6.3")
>     set(qtbi_orig_staging_prefix "/Users/qt/work/install/target")
dmcinnes@dmcinnes-System-Product-Name:~/git/victron/gui-v2$ diff /opt/Qt/6.6.3/wasm_singlethread/lib/cmake/Qt6BuildInternals/QtBuildInternalsExtra.cmake /opt/hostedtoolcache/Qt/6.6.3/wasm_singlethread/lib/cmake/Qt6BuildInternals/QtBuildInternalsExtra.cmake
45,46c45,46
<     set(qtbi_orig_prefix "/opt/Qt")
<     set(qtbi_orig_staging_prefix "/opt/Qt/6.6.3/wasm_singlethread")
---
>     set(qtbi_orig_prefix "C:/Qt/Qt-6.6.3")
>     set(qtbi_orig_staging_prefix "/Users/qt/work/install/target")
dmcinnes@dmcinnes-System-Product-Name:~/git/victron/gui-v2$

Code of Conduct

  • I agree to follow this project's Code of Conduct
@DanielMcInnes DanielMcInnes added bug Something isn't working triage labels Aug 6, 2024
@miurahr
Copy link
Owner

miurahr commented Aug 7, 2024

aqtinstall do not have a feature to patch cmake files.

We may need to add a new function to patch cmake file in Update class.
https://github.com/miurahr/aqtinstall/blob/master/aqt/updater.py#L269

Fortunately, we have already had a method to patch text files, but we need to determine conditions.

  • Which files to be patched?
  • Which architecture is required to update?

Currently, we don't modify anythings for wasm. Is it also affected in android?

@miurahr miurahr added enhancement New feature or request and removed bug Something isn't working triage labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants