Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CI failed: combination detection #807

Closed
1 task done
miurahr opened this issue Jul 28, 2024 · 7 comments
Closed
1 task done

[Bug]: CI failed: combination detection #807

miurahr opened this issue Jul 28, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@miurahr
Copy link
Owner

miurahr commented Jul 28, 2024

Bug description

CI combination.json failed

Expected behavior

Run CI without error

aqt and python version

Python 3.12

Operating System

Linux/Unix

Relevant log output

INFO    : Fetching arches
Traceback (most recent call last):
  File "/home/runner/work/aqtinstall/aqtinstall/ci/generate_combinations.py", line 215, in <module>
    main(filename=json_filename, is_write_file=args.write, is_verbose=args.verbose)
  File "/home/runner/work/aqtinstall/aqtinstall/ci/generate_combinations.py", line 147, in main
    actual = [generate_combos(new_archive=expect[0]["new_archive"])]
  File "/home/runner/work/aqtinstall/aqtinstall/ci/generate_combinations.py", line 120, in generate_combos
    "qt": merge_records(iter_arches()),
  File "/home/runner/work/aqtinstall/aqtinstall/ci/generate_combinations.py", line 108, in merge_records
    for record in arch_records:
  File "/home/runner/work/aqtinstall/aqtinstall/ci/generate_combinations.py", line 48, in iter_arches
    for arch_name in MetadataFactory(archive_id, architectures_ver=version).getList():
  File "/home/runner/work/aqtinstall/aqtinstall/aqt/metadata.py", line 620, in getList
    return self._action()
  File "/home/runner/work/aqtinstall/aqtinstall/aqt/metadata.py", line 600, in <lambda>
    self._action = lambda: self.fetch_arches(self._to_version(ver_str, None))
  File "/home/runner/work/aqtinstall/aqtinstall/aqt/metadata.py", line 720, in _to_version
    raise CliInputError(msg)
aqt.exceptions.CliInputError: There is no latest version of Qt with the criteria 'qt/all_os/qt'

Code of Conduct

  • I agree to follow this project's Code of Conduct
@miurahr miurahr added bug Something isn't working triage labels Jul 28, 2024
@pzhlkj6612
Copy link
Contributor

Is this the chance to drop the offline validation? #748.

@miurahr
Copy link
Owner Author

miurahr commented Jul 28, 2024

Lets do it!

@pzhlkj6612
Copy link
Contributor

Is there something I can help?

@miurahr
Copy link
Owner Author

miurahr commented Jul 28, 2024

I think we can remove lines https://github.com/miurahr/aqtinstall/blob/master/aqt/installer.py#L420-L423 and related methods. Could you try the modification? If it works, it is a chance to raise Pull-Request.

@miurahr
Copy link
Owner Author

miurahr commented Aug 4, 2024

I have tried and raised a pull-request to remove combinations.json related codes at #812
@pzhlkj6612 could you mind to review the change?

@miurahr miurahr removed the triage label Aug 5, 2024
@pzhlkj6612
Copy link
Contributor

could you mind to review the change?

I'll look into that PR in 3 days.

@pzhlkj6612
Copy link
Contributor

@miurahr , this issue should be closed.

@miurahr miurahr closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants