Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 Image #80

Open
neilclark-bgn opened this issue Sep 6, 2022 · 8 comments
Open

ARM64 Image #80

neilclark-bgn opened this issue Sep 6, 2022 · 8 comments

Comments

@neilclark-bgn
Copy link

Currently we run a mixture of AMD64 and ARM64 nodes in our clusters, and are slowly moving more workloads to AWS ARM based Graviton nodes due to to the lower running costs.

The secret generator is incredibly useful to us and we run it in all of our clusters. Please would you consider building a multi-arch image including support for ARM64. This would aid us in our plan to run ARM64 only clusters in future.

@mittwald-machine
Copy link
Collaborator

There has not been any activity to this issue in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

@martin-helmich
Copy link
Member

Sorry, this should not have gotten stale. This is a valid request, but I cannot make any promises as to when we'd be getting around to it. In the meantime, PRs are welcome. 🙂

@devfaz
Copy link

devfaz commented Jan 28, 2023

Would also be interested in having this feature 👍

@anon-software
Copy link

My issue for the same feature #77 also turned stale and was automatically closed. I was able to build one myself from the source code at the time. If you are interested, you can get the image from anonsoftware28/kubernetes-secret-generator repository in docker.io. The link to it is https://hub.docker.com/r/anonsoftware28/kubernetes-secret-generator.

And before you ask, it is not nearly ready for a proper pull request. Similarly to the official code, it only generates ARM64 image, but ideally we want them all. I remember jumping through the hoops to upload that image, it was not nearly as automated as it should be.

If it helps anything, I can run a diff on my local repository. I do not guarantee it is in the state it was when I generated the image, but it may serve as a starting point for somebody. I do not see myself getting into it any time soon.

@devfaz
Copy link

devfaz commented Apr 1, 2023

@anon-software would be nice if you could provide some hints/diff how you build the code for arm, may help others to continue here.

@steveannett
Copy link

steveannett commented Nov 8, 2023

@anon-software has a fork, the difference is here. This issue would have been great candidate for Hacktoberfest, but hopefully someone will be able to offer a solution before the next one.

@ab77
Copy link

ab77 commented Nov 10, 2023

I feel like the ideal way to do this, is to update the existing workflow to a matrix build, broadly following this approach.

For my (immediate and selfish) purposes however, I shimmed an extra build job in front of our CI script (which was already 80%+ there) to build the operator binaries and then inject them into the CI docker-bake workflow. Images are in the public ghcr.io registry. Please feel free to consume:

docker pull ghcr.io/belodetek/kubernetes-secret-generator:v0.0.3

To update, open a PR with a submodule digest bump.

@Fenrur
Copy link

Fenrur commented Feb 1, 2024

It bothers me to have to manage a registry with the Arm image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants