Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspec2xccdf does not generate benchmark metadata that matches DISA's #92

Open
rlakey opened this issue Aug 27, 2021 · 6 comments
Open
Labels
bug Something isn't working

Comments

@rlakey
Copy link

rlakey commented Aug 27, 2021

When generating xccdf with inspec_tools and importing it into STIG Viewer it does not display the same metadata at the top of a control as a DISA generated xccdf.

inspec_tools example:

<Benchmark xmlns="http://checklists.nist.gov/xccdf/1.1" xmlns:cpe="http://cpe.mitre.org/language/2.0" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:dsig="http://www.w3.org/2000/09/xmldsig#" xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" id="VMW_Photon_OS_3.0_STIG_Readiness_Guide">
  <status date="20 Jul 2021">draft</status>
  <title>VMware Photon OS 3.0 STIG Readiness Guide</title>
  <reference href="https://github.com/vmware/dod-compliance-and-automation/tree/master/photon/3.0">
    <dc:publisher>VMware</dc:publisher>
    <dc:source>https://github.com/vmware/dod-compliance-and-automation</dc:source>
  </reference>
  <version>1, Release: 2</version>

image

Updated to match DISA:

<?xml-stylesheet type='text/xsl' href='STIG_unclass.xsl'?>
<Benchmark
	xmlns:dc="http://purl.org/dc/elements/1.1/"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xmlns:cpe="http://cpe.mitre.org/language/2.0"
	xmlns:xhtml="http://www.w3.org/1999/xhtml"
	xmlns:dsig="http://www.w3.org/2000/09/xmldsig#" xsi:schemaLocation="http://checklists.nist.gov/xccdf/1.1 http://nvd.nist.gov/schema/xccdf-1.1.4.xsd http://cpe.mitre.org/dictionary/2.0 http://cpe.mitre.org/files/cpe-dictionary_2.1.xsd" id="VMW_Photon_OS_3.0_STIG_Readiness_Guide" xml:lang="en"
	xmlns="http://checklists.nist.gov/xccdf/1.1">
	<status date="2021-07-20">draft</status>
	<title>VMware Photon OS 3.0 STIG Readiness Guide</title>
	<description>This project represents VMware's effort to document our compliance against the SRG requirements and nothing more. A published STIG is our eventual goal, in most cases, but this content should not be viewed to be "as good as a STIG". A DISA published STIG includes technical validation, review of requirement fulfillment, accuracy and style, risk acceptance and is digitally signed by the RME and posted on a .mil. This SRG content is intended to provided value to our partners while the STIGs are in process. Except for products that have published STIGs already, there is no explicit or implied DISA approval of the provided content.</description>
	<notice id="terms-of-use" xml:lang="en"></notice>
	<front-matter xml:lang="en"></front-matter>
	<rear-matter xml:lang="en"></rear-matter>
	<reference href="https://github.com/vmware/dod-compliance-and-automation">
		<dc:publisher>VMware</dc:publisher>
		<dc:source>https://github.com/vmware/dod-compliance-and-automation</dc:source>
	</reference>
	<plain-text id="release-info">Release: 2 Benchmark Date: 20 Jul 2021</plain-text>
	<plain-text id="generator">3.2.2.36079</plain-text>
	<plain-text id="conventionsVersion">1.10.0</plain-text>
	<version>1</version>

image

@Bialogs
Copy link

Bialogs commented Sep 8, 2021

related mitre/inspec_tools#212

@Bialogs
Copy link

Bialogs commented Sep 9, 2021

@rlakey is this behavior present when you are using a a metadata.json to provide this information?

@aaronlippold aaronlippold added the bug Something isn't working label Sep 11, 2021
@aaronlippold
Copy link
Member

Is this closed by mitre/inspec_tools#246

@Bialogs
Copy link

Bialogs commented Sep 13, 2021

I don't think so because this is discussing inspec2xccdf not inspec2ckl.

@rlakey
Copy link
Author

rlakey commented Sep 13, 2021

@rlakey is this behavior present when you are using a a metadata.json to provide this information?

I haven't tried that since I was assuming this would come from the attributes yaml.

@TMVUONG-HI
Copy link

Sorry about asking a beginner's (Inspec/Ruby) question here because I don't where to pose it - how do I set up Inspec_Tools on a Windows machine (running inspec-4.50.3.1-x64 and rubyinstaller-3.0.3-1-x64.exe)? I have recently started to use a Powershell script, but can't seem to get the call to inspec_tools command to work.

        $cklCommand = {inspec_tools inspec2ckl -j $reportFile -o $cklFile}
        Invoke-Command -ScriptBlock $cklCommand

@camdenmoors camdenmoors transferred this issue from mitre/inspec_tools Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants