-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow multi-inheritance pattern for all applicable detectors #61
Comments
To complete the refactor, it is first necessary to determine:
Note that a detector being exclusively batch/streaming should not prevent us from isolating as much 'other' logic into the parent algorithm class as possible. Currently: Streaming only:
Batch only:
Both:
|
Optionally, multiple branches can be made to develop on each of the involved detectors and linked into one PR for this issue. |
Checking these off as I go -- not necessarily setting them up with maximum possible refactoring into a parent class, but making sure that they each inherit the proper ABC. |
@tms-bananaquit sounds good; later we can push the parent class concept if we know that certain of these detectors may need to be both streaming/batch |
@Anmol-Srivastava Going to go ahead and close unless there's objection. #70 can finish deprecating |
Task
After #46, all remaining detectors outside of
KdqTree
will need to be updated, to now use theStreamingDetector
andBatchDetector
ABCs if they are meant to service both options. Such detectors will (likely) also need to implement their own parent algorithm class, e.g.KdqTreeDetector
as part of the multi-inheritance pattern.Impact
This will significantly progress the broad refactor of the drift detectors' object design. See also #15
The text was updated successfully, but these errors were encountered: