Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to init params where applicable. #42

Open
tms-bananaquit opened this issue Jun 17, 2022 · 0 comments
Open

Add validation to init params where applicable. #42

tms-bananaquit opened this issue Jun 17, 2022 · 0 comments

Comments

@tms-bananaquit
Copy link
Collaborator

For example, I don't believe most of the window-based detectors check that the window size is greater than 0.
For detectors where the parameters have theoretical restrictions (i.e. probabilities are on [0,1]) we ought to drop ValidationError too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant