-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about evaluation results and demo #39
Comments
Thank you for taking a closer look at our paper and for raising these questions. Let me address them in detail:
I hope my clarifications have helped you better understand your questions. Feel free to let me know if there's anything else I can help with. Guangxuan |
Thanks again for your reply! Really helped me understands better. |
c-recompute-window-attention
behaves close to streaming-llm on ppl, but table1 says that "window" attention has poor performance on ppl, so I guess table1 usesb-naive-window-attention
? And table5 says that "window" attention fails in ARC benchmark, so I guess this is alsob-naive-window-attention
? Then in figure10, it says that the speedup is benchmarked withc-recompute-window-attention
. Could you benchmark ALL results with BOTH "window-attention" methods to make the comparison fair? Or did I miss anything?Thanks in advance!
The text was updated successfully, but these errors were encountered: