Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMSNorm implemented as LayerNorm #32

Open
jason-huang03 opened this issue Aug 21, 2024 · 0 comments
Open

RMSNorm implemented as LayerNorm #32

jason-huang03 opened this issue Aug 21, 2024 · 0 comments

Comments

@jason-huang03
Copy link

Inside rms_norm_general it seems that this function invokes layer norm kernel with beta set to nullptr. However, this does not seem to be equivalent to the RMSNorm, which skip the mean subtraction from input features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason-huang03