Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish coordinator/provider/acomm #48

Open
bbickerton opened this issue Mar 11, 2016 · 1 comment
Open

Polish coordinator/provider/acomm #48

bbickerton opened this issue Mar 11, 2016 · 1 comment

Comments

@bbickerton
Copy link
Member

Review function signatures and flows after a real provider (e.g. #40 ) has used them. Find anything that doesn't work well or feels clunky and address before making more providers.

@mmlb
Copy link
Member

mmlb commented Mar 11, 2016

adding "" for arg in NewRequest is particularly wrong looking. Maybe NewRequest should just take in the args it needs for validation and returns a default+validated-args Request instead of filling it all in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants