Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualTourPlugin not working properly with AutorotatePlugin and StereoPlugin #1449

Closed
zatakiya opened this issue Oct 2, 2024 · 4 comments
Closed
Labels
Milestone

Comments

@zatakiya
Copy link

zatakiya commented Oct 2, 2024

Describe the bug

While using auto rotate plugin with virtual tour, autorotation stops after the node is changed.

Also, when StereoPlugin is activated and clicked anywhere on the screen (including link arrow button), one side of screen just disappears

Seems like StereoPlugin is currently not supported to work with VirtualTourPlugin, but it could be a very good addition.

Online demo URL

No response

Photo Sphere Viewer version

5.10.1

Plugins loaded

VirtualTourPlugin, AutorotatePlugin, GyroscopePlugin, StereoPlugin

OS & browser

Tested in windows(Chrome) and ios(Safari).

Additional context

I am using this in nextjs project, with react-photo-sphere-viewer framework. Not sure if this issue is related to react-photo-sphere-viewer only or not.

@zatakiya zatakiya added the bug label Oct 2, 2024
@mistic100 mistic100 added this to the 5.10.2 milestone Oct 2, 2024
@mistic100
Copy link
Owner

I made some changes to improve the integration of the autorotate feature inside virtual-tour : the rotation will still stops when changing node, because this is considered a user interraction, but it will re-start again if autostartOnIdle: true (the default).

I do not plan to make improvements on the stereo integration, I don't think there is a real usage of cardboards justifying to fix each edge case.

@zatakiya
Copy link
Author

zatakiya commented Oct 2, 2024

Thanks for the quick reply

I believe making stereo plugin compatible with virtual tour can enable the functionality to view virtual tour in VR headsets. Or am I missing something here?

@mistic100
Copy link
Owner

the stereo plugin is not an XR renderer, there is another issue for that #571 which I do not work on

Copy link

This feature/bug fix has been released in version 5.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants