Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-strict output verification. #12

Open
misaim opened this issue Nov 15, 2022 · 2 comments
Open

Add non-strict output verification. #12

misaim opened this issue Nov 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@misaim
Copy link
Owner

misaim commented Nov 15, 2022

Currently output file verification is reasonably strict:

re.sub('[^0-9a-zA-Z\.,:%\-_#]+', '', ebl_file['header_3']['filename'])

We should add a new flag and a secondary regex which allows some chars through for OS's where it doesn't matter - i.e Mac OS X and Linux both allow !, ? and ' ' chars in filenames, although windows doesn't.

Could also look at replacing some strings. '/w' is used for shorthand "with", / is used for time sig's and could be "slash" or a dash.

@misaim misaim added the enhancement New feature or request label Nov 15, 2022
@jackbucinskas
Copy link
Collaborator

We should add a new flag and a secondary regex which allows some chars through for OS's where it doesn't matter - i.e Mac OS X and Linux both allow !, ? and ' ' chars in filenames, although windows doesn't.

Disagree.

@misaim
Copy link
Owner Author

misaim commented Nov 17, 2022

Why disagree? Some chars are used - Like ' ' is perfectly fine. Known shortenings also. Some music-specific stuff too (# for sharp, * seems to be used for something(?), etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants