Description
This is related to a comment made on #52 that was out of context for the issue where it was added to.
We've defined a mutation to work with basic updates on our MembershipInstance
model, we defined this schema
const schema = {
type Membership {
id: ID!
name: String!
membershipInstances(id: ID): [MembershipInstance]
}
type MembershipInstance {
id: ID!
...
}
type Mutation {
updateMembershipInstance(input: UpdateMembershipInstanceInput): UpdateMembershipInstanceResponse
}
input UpdateMembershipInstanceInput {
id: ID!
name: String!
}
union UpdateMembershipInstanceResponse = UpdateMembershipInstanceSuccess | Error
type UpdateMembershipInstanceSuccess {
membershipInstance: MembershipInstance
}
type Error {
message: String
}
}
and we have this mutation handler on our resolvers we're passing to createGraphQLHandler(...)
const resolvers = {
updateMembershipInstance: (parent, args, context, info) => {
const { mirageServer } = context
const { id: membershipInstanceId } = args.input
const membershipInstance = mirageServer.schema.membershipInstance.find(membershipInstanceId)
if (membershipInstance) {
membershipInstance.update(args.input)
}
const response = new UpdateMembershipInstanceSuccess()
response.membershipInstance = membershipInstance
return response
}
}
export class UpdateMembershipInstanceSuccess {
get __typename () {
return 'UpdateMembershipInstanceSuccess'
}
}
this code, as is, works, but we're wondering if this is the graphql way to do things, specially because we're calling mirage directly to update records, then we're also building a typed response to avoid graphql union errors. What we're discussing with the rest of the team is if this shouldn't have a different handler, deferring the actual data update work to mirage/graphql, we tried this also
const resolvers = {
updateMembershipInstance: {
__typename: 'UpdateMembershipInstanceResponse',
__resolveType: (obj, context, info) => {
debugger
},
resolveType: (obj, context, info) => {
debugger
},
__returnType: () => {
debugger
},
returnType: () => {
debugger
}
},
UpdateMembershipInstanceResponse: {
__resolveType: (obj, context, info) => {
debugger
},
resolveType: (obj, context, info) => {
debugger
},
__returnType: () => {
debugger
},
returnType: () => {
debugger
}
},
updateMembershipInstance: (parent, args, context, info) => {
const membershipInstance = mirageGraphQLFieldResolver(...arguments)
const response = new UpdateMembershipInstanceSuccess()
response.membershipInstance = membershipInstance
return response
}
}
export class UpdateMembershipInstanceSuccess {
get __typename () {
return 'UpdateMembershipInstanceSuccess'
}
}
but this approach fails, with this error
TypeError: Cannot read properties of undefined (reading 'returnType') at mirageGraphQLFieldResolver
{
"message": "Cannot read properties of undefined (reading 'returnType')",
"locations": [
{
"line": 2,
"column": 3
}
],
"path": [
"updateMembershipInstance"
]
}
which makes me thing we're not using mirageGraphQLFieldResolver
correctly, but what I find specially confusing is that we also added returnType
to our types resolvers, but it seems we're not even hitting those, and we cannot still find which type from our schema this error is originating from
any help or comment would be super welcomed!