Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review handling of fixed-length types and Type.size_of #5

Open
craigfe opened this issue Oct 14, 2020 · 0 comments
Open

Review handling of fixed-length types and Type.size_of #5

craigfe opened this issue Oct 14, 2020 · 0 comments

Comments

@craigfe
Copy link
Member

craigfe commented Oct 14, 2020

Type.size_of currently behaves oddly in the case where it is passed:

  • a representation of a fixed-length type; and
  • a value that does not have that length.

We should decide on a consistent strategy for dealing with these cases. See discussion in mirage/irmin#1030 (comment).

(Originally reported at mirage/irmin#1037.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craigfe