Skip to content

Commit a1933f9

Browse files
committed
Update to Cmdliner.1.1.0
1 parent 0de355b commit a1933f9

File tree

11 files changed

+59
-58
lines changed

11 files changed

+59
-58
lines changed

.ocamlformat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version=0.20.0
1+
version=0.20.1
22
module-item-spacing=compact
33
break-infix=fit-or-vertical
44
parens-tuple=multi-line-only

bin/carton/get.ml

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ let run hxd path info raw pack uid_or_offset =
117117

118118
let run hxd path info raw pack uid_or_offset =
119119
match run hxd path info raw pack uid_or_offset with
120-
| Ok () -> `Ok 0
121-
| Error (`Msg err) -> `Error (false, Fmt.str "%s." err)
120+
| Ok () -> Ok ()
121+
| Error (`Msg err) -> Error (Fmt.str "%s." err)
122122

123123
open Cmdliner
124124

@@ -166,7 +166,6 @@ let uid_or_offset =
166166

167167
let cmd =
168168
let doc = "Extract an object from a PACK file." in
169-
let exits = Term.default_exits in
170169
let man =
171170
[
172171
`S Manpage.s_description;
@@ -175,15 +174,15 @@ let cmd =
175174
offset.";
176175
]
177176
in
178-
( Term.(
179-
ret
180-
(const run
181-
$ Hxd_cmdliner.cmd
182-
$ with_path
183-
$ with_info
184-
$ raw
185-
$ pack
186-
$ uid_or_offset)),
187-
Term.info "get" ~doc ~exits ~man )
188-
189-
let () = Term.(exit_status @@ eval cmd)
177+
let info = Cmd.info "get" ~doc ~man in
178+
Cmd.v info
179+
Term.(
180+
const run
181+
$ Hxd_cmdliner.cmd
182+
$ with_path
183+
$ with_info
184+
$ raw
185+
$ pack
186+
$ uid_or_offset)
187+
188+
let () = exit @@ Cmd.eval_result cmd

bin/carton/hxd_cmdliner.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ let style_renderer ?env () =
340340
Arg.(value & opt color None & info [ "color" ] ?env ~doc ~docv:"<when>")
341341

342342
let setup_fmt =
343-
let env = Arg.env_var "HXD_COLOR" in
343+
let env = Cmd.Env.info "HXD_COLOR" in
344344
Term.(const run_fmt $ style_renderer ~env ())
345345

346346
let cmd = Term.(const make $ setup_fmt $ cols $ groupsize $ uppercase $ pixel)

bin/carton/index_pack.ml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -350,8 +350,8 @@ let index_pack ?(verbose = false) src dst =
350350

351351
let run verbose src dst =
352352
match (Fiber.run <.> prj) (index_pack ~verbose src dst) with
353-
| Ok () -> `Ok 0
354-
| Error (`Msg err) -> `Error (false, Fmt.str "%s." err)
353+
| Ok () -> Ok ()
354+
| Error (`Msg err) -> Error (Fmt.str "%s." err)
355355

356356
open Cmdliner
357357

@@ -388,16 +388,15 @@ let verbose =
388388

389389
let cmd =
390390
let doc = "Build pack index for an packed archive." in
391-
let exits = Term.default_exits in
392391
let man =
393392
[
394393
`S Manpage.s_description;
395394
`P
396-
"Readss a packed archive (.pack) from a specified file (or standard \
395+
"Reads a packed archive (.pack) from a specified file (or standard \
397396
input), and builds a pack index file (.idx) for it.";
398397
]
399398
in
400-
( Term.(ret (const run $ verbose $ src $ dst)),
401-
Term.info "index-pack" ~doc ~exits ~man )
399+
let info = Cmd.info "index-pack" ~doc ~man in
400+
Cmd.v info Term.(const run $ verbose $ src $ dst)
402401

403-
let () = Term.(exit_status @@ eval cmd)
402+
let () = exit @@ Cmd.eval_result cmd

bin/carton/verify_pack.ml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -271,8 +271,8 @@ let run ~verbose fpath =
271271

272272
let run verbose fpath =
273273
match Fiber.run (run ~verbose fpath) with
274-
| Ok () -> `Ok 0
275-
| Error (`Msg err) -> `Error (false, Fmt.str "%s." err)
274+
| Ok () -> Ok ()
275+
| Error (`Msg err) -> Error (Fmt.str "%s." err)
276276

277277
open Cmdliner
278278

@@ -298,7 +298,6 @@ let fpath =
298298

299299
let cmd =
300300
let doc = "Validate packed Git archive files" in
301-
let exits = Term.default_exits in
302301
let man =
303302
[
304303
`S Manpage.s_description;
@@ -308,7 +307,7 @@ let cmd =
308307
pack file.";
309308
]
310309
in
311-
( Term.(ret (const run $ verbose $ fpath)),
312-
Term.info "verify-pack" ~doc ~exits ~man )
310+
let info = Cmd.info "verify-pack" ~doc ~man in
311+
Cmd.v info Term.(const run $ verbose $ fpath)
313312

314-
let () = Term.(exit_status @@ eval cmd)
313+
let () = exit @@ Cmd.eval_result cmd

bin/guit/fetch.ml

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ open Cmdliner
8888
* [--progress] <repository> <refspec>... *)
8989

9090
let output =
91-
let conv' =
91+
let converter =
9292
let parse str =
9393
match str with
9494
| "stdout" -> Ok Fmt.stdout
@@ -104,7 +104,8 @@ let output =
104104
"Output of the progress status. Can take values 'stdout' (default) or \
105105
'stderr'."
106106
in
107-
Arg.(value & opt conv' Fmt.stdout & info [ "output" ] ~doc ~docv:"<output>")
107+
Arg.(
108+
value & opt converter Fmt.stdout & info [ "output" ] ~doc ~docv:"<output>")
108109

109110
let directory =
110111
let doc = "Indicate path to repository root containing '.git' folder" in
@@ -137,18 +138,22 @@ let references =
137138
& info ~doc ~docv:"<ref>" [])
138139

139140
let setup_logs =
141+
let docs = Manpage.s_common_options in
140142
Term.(
141-
const setup_logs $ Fmt_cli.style_renderer () $ Logs_cli.level () $ output)
143+
const setup_logs
144+
$ Fmt_cli.style_renderer ~docs ()
145+
$ Logs_cli.level ~docs ()
146+
$ output)
142147

143148
let main (quiet, _) references directory repository =
144149
match Lwt_main.run (main quiet references directory repository) with
145-
| Ok () -> `Ok ()
146-
| Error (#error as err) -> `Error (false, Fmt.str "%a." pp_error err)
150+
| Ok () -> Ok ()
151+
| Error (#error as err) -> Error (Fmt.str "%a." pp_error err)
147152

148153
let command =
149154
let doc = "Fetch a Git repository." in
150-
let exits = Term.default_exits in
151-
( Term.(ret (const main $ setup_logs $ references $ directory $ repository)),
152-
Term.info "fetch" ~doc ~exits )
155+
let info = Cmd.info "fetch" ~doc in
156+
Cmd.v info
157+
Term.(const main $ setup_logs $ references $ directory $ repository)
153158

154-
let () = Term.(exit @@ eval command)
159+
let () = exit @@ Cmd.eval_result command

bin/guit/v.ml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ let main quiet path =
6565

6666
let main logs path =
6767
match Lwt_main.run (main logs path) with
68-
| Ok () -> `Ok 0
69-
| Error (`Msg err) -> `Error (false, Fmt.str "%s." err)
68+
| Ok () -> Ok ()
69+
| Error (`Msg err) -> Error (Fmt.str "%s." err)
7070

7171
open Cmdliner
7272

@@ -80,11 +80,13 @@ let directory =
8080
& info [ "r"; "root" ] ~doc ~docv:"<directory>")
8181

8282
let setup_logs =
83-
Term.(const setup_logs $ Fmt_cli.style_renderer () $ Logs_cli.level ())
83+
let docs = Manpage.s_common_options in
84+
Term.(
85+
const setup_logs $ Fmt_cli.style_renderer ~docs () $ Logs_cli.level ~docs ())
8486

8587
let command =
8688
let doc = "Make a Git repository." in
87-
let exits = Term.default_exits in
88-
Term.(ret (const main $ setup_logs $ directory)), Term.info "v" ~doc ~exits
89+
let info = Cmd.info "v" ~doc in
90+
Cmd.v info Term.(const main $ setup_logs $ directory)
8991

90-
let () = Term.(exit @@ eval command)
92+
let () = exit @@ Cmd.eval_result command

carton.opam

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ depends: [
2323
"checkseum" {>= "0.3.2"}
2424
"logs"
2525
"bigarray-compat"
26-
"cmdliner" {>= "1.0.4"}
27-
"hxd" {>= "0.3.0"}
26+
"cmdliner" {>= "1.1.0"}
27+
"hxd" {>= "0.3.2"}
2828
"psq" {>= "0.2.0"}
2929
"fmt" {>= "0.8.9"}
3030
"result"
@@ -37,7 +37,7 @@ depends: [
3737
"base-unix" {with-test}
3838
"base-threads" {with-test}
3939
"alcotest" {with-test}
40-
"crowbar" {with-test & >= "0.2"}
40+
"crowbar" {with-test & >= "0.2.1"}
4141
"alcotest-lwt" {>= "1.2.3" & with-test}
4242
"lwt" {>= "5.3.0" & with-test}
4343
"ocamlfind" {>= "1.8.1" & with-test}

git-unix.opam

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ depends: [
3434
"awa" {>= "0.1.0"}
3535
"mirage-time" {>= "2.0.0"}
3636
"mirage-unix" {>= "5.0.0"}
37-
"cmdliner" {>= "1.0.4"}
37+
"cmdliner" {>= "1.1.0"}
3838
"decompress" {>= "1.4.0"}
3939
"domain-name" {>= "0.3.0"}
4040
"ipaddr" {>= "5.0.1"}

git.opam

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,17 @@ depends: [
4343
"alcotest" {with-test & >= "1.1.0"}
4444
"alcotest-lwt" {with-test & >= "1.1.0"}
4545
"mirage-crypto-rng" {with-test & >= "0.8.0"}
46-
"cmdliner" {with-test}
46+
"cmdliner" {with-test & >= "1.1.0"}
4747
"base-unix" {with-test}
4848
"fpath"
49-
"hxd" {>= "0.3.1"}
49+
"hxd" {>= "0.3.2"}
5050
"mirage-flow" {>= "2.0.1"}
5151
"domain-name" {>= "0.3.0"}
5252
"emile" {>= "1.1"}
5353
"ipaddr" {>= "5.0.1"}
5454
"psq" {>= "0.2.0"}
5555
"uri" {>= "4.1.0"}
56-
"crowbar" {>= "0.2" & with-test}
56+
"crowbar" {>= "0.2.1" & with-test}
5757
]
5858
build: [
5959
["dune" "build" "-p" name "-j" jobs]

0 commit comments

Comments
 (0)