Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mint start dependency installation answer detection #711

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

jhf
Copy link
Contributor

@jhf jhf commented Nov 21, 2024

The current code for mint start does not allow usage of return/enter to select the default option of Y(es).
Example run with current mint when pressing Return to select Y

➜  ui git:(feature/mint-prototype) mint tool clean
Mint - Removing directories
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Nothing to delete.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
All done in 25μs!
➜  ui git:(feature/mint-prototype) mint start
Mint - Running the development server
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
⚙ Ensuring dependencies...
 ↳ Not all dependencies in your mint.json file are installed.
   Would you like to install them now? (Y/n)


⚠ Missing dependencies...━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
There was an error, exiting...

Example run with this fix when pressing Return to select Y

➜  ui git:(feature/mint-prototype) ~/Projects/mint/bin/mint tool clean
Mint - Removing directories
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Nothing to delete.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
All done in 31μs!
➜  ui git:(feature/mint-prototype) ~/Projects/mint/bin/mint start
Mint - Running the development server
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
⚙ Ensuring dependencies...
 ↳ Not all dependencies in your mint.json file are installed.
   Would you like to install them now? (Y/n)

⚙ Constructing dependency tree...
  ✔ Updated mint-ui (https://github.com/mint-lang/mint-ui.git)
  ✔ Updated mint-color (https://github.com/mint-lang/mint-color.git)

⚙ Resolving dependency tree...
  ◈ mint-ui ➔ 8.0.0
  ◈ mint-color ➔ 0.9.0

⚙ Copying packages...
⚙ Development server started on http://0.0.0.0:3000/
^C
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Aborted! Exiting...

@gdotdesign gdotdesign added the enhancement New feature or request label Nov 21, 2024
@gdotdesign gdotdesign added this to the 0.21.0 milestone Nov 21, 2024
@gdotdesign gdotdesign merged commit 29eddc6 into mint-lang:master Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants