Improve debugging of Mint values. #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how Mint values (types) are printed. Before this PR, when using
Debug.logordbgthe JavaScript versions of values are being printed to the console:Which is OK, but we can do better. This PR changes that to this:
Basically, we instrument the generated code, injecting the name of the records and variants so we can pretty print them.
If we are using
dbgwe have a location as well (this is not new):Other things:
Debug.inspectwhich returns the pretty printed version.Debug.logremains as-is printing the raw values.dbgis now using the pretty printed version by default, to get the raw value we can usedbg!Resolves #641.