Skip to content

Commit 47bf31b

Browse files
committed
Update eslint-plugin-import
2.28.0 introduced a breaking change to `import/order` where the order of nested groups (whose purpose is to define different types of imports that are of equivalent rank) started to matter: a single nested group would be treated as though it wasn't nested We [got around this][1] by adding a second nested group with most if not all of the other import types we use It looks like #141 brought us back to 2.27.5. If we go back to 2.28.0 now and revert to the simpler config, for some reason the ESLint errors don't reappear In any case, I submitted a [bug fix][2] in eslint-plugin-import 💅 This was released in 2.28.1, so we should upgrade, hopefully preventing an unexpected return to confusing errors [1]: ab5a73e [2]: import-js/eslint-plugin-import#2854
1 parent ab8a4cd commit 47bf31b

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

.eslintrc.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,7 @@
105105
"error",
106106
{
107107
"alphabetize": { "order": "asc", "orderImportKind": "asc" },
108-
"groups": [
109-
["builtin", "external"],
110-
["internal", "parent", "sibling"]
111-
],
108+
"groups": [["builtin", "external"]],
112109
"newlines-between": "always"
113110
}
114111
],

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
"eslint-config-prettier": "^9.0.0",
122122
"eslint-import-resolver-typescript": "^3.5.5",
123123
"eslint-plugin-cypress": "^2.13.2",
124-
"eslint-plugin-import": "^2.27.5",
124+
"eslint-plugin-import": "^2.28.1",
125125
"eslint-plugin-no-only-tests": "^3.1.0",
126126
"eslint-plugin-prettier": "^5.0.0",
127127
"eslint-plugin-sort-exports": "^0.8.0",

0 commit comments

Comments
 (0)