Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type lifeCycleRule incorrect #1306

Closed
juliebrunetto83 opened this issue Jun 17, 2024 · 4 comments
Closed

type lifeCycleRule incorrect #1306

juliebrunetto83 opened this issue Jun 17, 2024 · 4 comments

Comments

@juliebrunetto83
Copy link

It seems that the typing of the Expiration key in lifeCycleRule is incorrect. Date, Days, DeleteMarker, DeleteAll have all become required since the last update. This creates a typing error when I call the setBucketLifecycle function.
What should I do ?

@prakashsvmx
Copy link
Member

export type LifecycleRule = {

Looks they are optional.

@juliebrunetto83
Copy link
Author

I was referring inside the Expiration key. Date, Days, DeleteMarker, DeleteAll, they are all required.

@prakashsvmx
Copy link
Member

export type Expiration = {

Yeah looks like.. we can mark them optional. Feel free to send a PR.

@prakashsvmx
Copy link
Member

fixed as part of #1308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants