Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for listening to global events #1110

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add support for listening to global events #1110

wants to merge 10 commits into from

Conversation

adelinag08
Copy link

@adelinag08 adelinag08 commented Jun 24, 2024 •
edited
Loading

This PR implements the following:

  • Introduce two new types of EventType that represent global events ( s3:BucketCreated:* and s3:BucketRemoved:*)
  • Add ListenNotificationsAsync that uses ListenBucketNotificationsAsync to listen for global notifications without a bucket name set

Resolves #1109

@adelinag08 adelinag08 marked this pull request as ready for review June 24, 2024 07:52
@ebozduman
Copy link
Collaborator

@adelinag08

Please run dotnet regitlint to address the formatting/lint issue(s).

ramondeklein
ramondeklein approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebozduman Can you also check?

ebozduman
ebozduman requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add tests to Minio.Functional.Tests for the new notifications as we run the functional tests for PRs.

@ebozduman
Copy link
Collaborator

It looks like dotnet regitlint needs to be run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramondeklein ramondeklein ramondeklein approved these changes

@ebozduman ebozduman ebozduman requested changes

@minio-trusted minio-trusted Awaiting requested review from minio-trusted

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for listening to Global Events
4 participants
@adelinag08 @ebozduman @ramondeklein @minio-trusted