Skip to content

Commit 2676e50

Browse files
authored
fix: redact sse key in debug logs (#5231)
1 parent f72d75d commit 2676e50

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

cmd/client-s3-trace_v4.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ func newTraceV4() httptracer.HTTPTracer {
3838
// Request - Trace HTTP Request
3939
func (t traceV4) Request(req *http.Request) (err error) {
4040
origAuth := req.Header.Get("Authorization")
41+
sseKey := req.Header.Get("X-Amz-Server-Side-Encryption-Customer-Key")
4142

4243
printTrace := func() error {
4344
reqTrace, rerr := httputil.DumpRequestOut(req, false) // Only display header
@@ -47,6 +48,11 @@ func (t traceV4) Request(req *http.Request) (err error) {
4748
return rerr
4849
}
4950

51+
if strings.TrimSpace(sseKey) != "" {
52+
// Stripe out SSE-C key from: X-Amz-Server-Side-Encryption-Customer-Key=<key>
53+
req.Header.Set("X-Amz-Server-Side-Encryption-Customer-Key", "**REDACTED**")
54+
}
55+
5056
if strings.TrimSpace(origAuth) != "" {
5157
// Authorization (S3 v4 signature) Format:
5258
// Authorization: AWS4-HMAC-SHA256 Credential=AKIAJNACEGBGMXBHLEZA/20150524/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=bbfaa693c626021bcb5f911cd898a1a30206c1fad6bad1e0eb89e282173bd24c

0 commit comments

Comments
 (0)