use separate Details struct and avoid interface{} or any

Author: Praveenrajmani

log/audit.go

@@ -63,6 +63,7 @@ const (
 	AuditCategoryIDP            AuditCategory = "idp"
 	AuditCategoryLogRecorder    AuditCategory = "log-recorder"
 	AuditCategoryHeal           AuditCategory = "heal"
+	AuditCategoryBatch          AuditCategory = "batch"
 )
 
 // AuditAction represents the type of action performed
@@ -87,6 +88,28 @@ const (
 	AuditActionDetach  AuditAction = "detach"
 )
 
+// AuditDetails is a union type containing category-specific audit details
+type AuditDetails struct {
+	Config          *ConfigAuditDetails          `json:"config,omitempty"`
+	User            *UserAuditDetails            `json:"user,omitempty"`
+	ServiceAccount  *ServiceAccountAuditDetails  `json:"serviceAccount,omitempty"`
+	Policy          *PolicyAuditDetails          `json:"policy,omitempty"`
+	Group           *GroupAuditDetails           `json:"group,omitempty"`
+	BucketConfig    *BucketConfigAuditDetails    `json:"bucketConfig,omitempty"`
+	BucketQuota     *BucketQuotaAuditDetails     `json:"bucketQuota,omitempty"`
+	BucketQOS       *BucketQOSAuditDetails       `json:"bucketQOS,omitempty"`
+	BucketInventory *BucketInventoryAuditDetails `json:"bucketInventory,omitempty"`
+	Tier            *TierAuditDetails            `json:"tier,omitempty"`
+	Service         *ServiceAuditDetails         `json:"service,omitempty"`
+	KMS             *KMSAuditDetails             `json:"kms,omitempty"`
+	Pool            *PoolAuditDetails            `json:"pool,omitempty"`
+	SiteRepl        *SiteReplicationAuditDetails `json:"siteRepl,omitempty"`
+	IDP             *IDPAuditDetails             `json:"idp,omitempty"`
+	Recorder        *RecorderAuditDetails        `json:"recorder,omitempty"`
+	Heal            *HealAuditDetails            `json:"heal,omitempty"`
+	Batch           *BatchAuditDetails           `json:"batch,omitempty"`
+}
+
 // Audit represents the user triggered audit events
 type Audit struct {
 	Version    string                 `json:"version"`
@@ -102,7 +125,7 @@ type Audit struct {
 	SourceHost string                 `json:"sourceHost,omitempty"`
 	AccessKey  string                 `json:"accessKey,omitempty"`
 	ParentUser string                 `json:"parentUser,omitempty"`
-	Details    interface{}            `json:"details,omitempty"`
+	Details    *AuditDetails          `json:"details,omitempty"`
 }
 
 // ConfigAuditDetails captures config mutation details
@@ -299,26 +322,170 @@ type HealAuditDetails struct {
 // Redact redacts sensitive fields in HealAuditDetails
 func (h *HealAuditDetails) Redact() {}
 
-// String returns a canonical string for Audit
+// BatchAuditDetails captures batch job operation details
+type BatchAuditDetails struct {
+	JobID   string `json:"jobID,omitempty"`
+	JobType string `json:"jobType,omitempty"`
+	User    string `json:"user,omitempty"`
+}
+
+// Redact redacts sensitive fields in BatchAuditDetails
+func (b *BatchAuditDetails) Redact() {}
+
+// Message returns a human-readable message for batch audit
+func (b BatchAuditDetails) Message() string {
+	if b.JobType != "" && b.JobID != "" {
+		return "Batch job '" + b.JobType + "' (" + b.JobID + ")"
+	}
+	if b.JobID != "" {
+		return "Batch job " + b.JobID
+	}
+	return "Batch job operation"
+}
+
+// Details returns specific parameter changes for batch audit
+func (b BatchAuditDetails) Details() string {
+	var parts []string
+	if b.User != "" {
+		parts = append(parts, "user:"+b.User)
+	}
+	return strings.Join(parts, " ")
+}
+
+// BucketQuotaAuditDetails captures bucket quota configuration changes
+type BucketQuotaAuditDetails struct {
+	BucketName string `json:"bucketName"`
+	QuotaSize  uint64 `json:"quotaSize,omitempty"`
+	QuotaType  string `json:"quotaType,omitempty"`
+}
+
+// Redact redacts sensitive fields in BucketQuotaAuditDetails
+func (q *BucketQuotaAuditDetails) Redact() {}
+
+// Message returns a human-readable message for bucket quota audit
+func (q BucketQuotaAuditDetails) Message() string {
+	if q.BucketName != "" {
+		return "Bucket quota for '" + q.BucketName + "'"
+	}
+	return "Bucket quota modified"
+}
+
+// Details returns specific parameter changes for bucket quota audit
+func (q BucketQuotaAuditDetails) Details() string {
+	var parts []string
+	if q.QuotaSize > 0 {
+		parts = append(parts, fmt.Sprintf("size:%d", q.QuotaSize))
+	}
+	if q.QuotaType != "" {
+		parts = append(parts, "type:"+q.QuotaType)
+	}
+	return strings.Join(parts, " ")
+}
+
+// BucketQOSAuditDetails captures bucket QoS configuration changes
+type BucketQOSAuditDetails struct {
+	BucketName string          `json:"bucketName"`
+	Enabled    bool            `json:"enabled"`
+	Rules      []QOSRuleDetail `json:"rules,omitempty"`
+}
+
+// QOSRuleDetail captures details of a single QoS rule
+type QOSRuleDetail struct {
+	ID           string `json:"id,omitempty"`
+	Label        string `json:"label,omitempty"`
+	Priority     int    `json:"priority,omitempty"`
+	ObjectPrefix string `json:"objectPrefix,omitempty"`
+	API          string `json:"api,omitempty"`
+	Rate         int64  `json:"rate,omitempty"`
+	Burst        int64  `json:"burst,omitempty"`
+	LimitType    string `json:"limitType,omitempty"`
+}
+
+// Redact redacts sensitive fields in BucketQOSAuditDetails
+func (q *BucketQOSAuditDetails) Redact() {}
+
+// Message returns a human-readable message for bucket QoS audit
+func (q BucketQOSAuditDetails) Message() string {
+	if q.BucketName != "" {
+		status := "disabled"
+		if q.Enabled {
+			status = "enabled"
+		}
+		return "Bucket QoS for '" + q.BucketName + "' " + status
+	}
+	return "Bucket QoS modified"
+}
+
+// Details returns specific parameter changes for bucket QoS audit
+func (q BucketQOSAuditDetails) Details() string {
+	if len(q.Rules) > 0 {
+		return fmt.Sprintf("rules:%d", len(q.Rules))
+	}
+	return ""
+}
+
+// BucketInventoryAuditDetails captures bucket inventory configuration changes
+type BucketInventoryAuditDetails struct {
+	BucketName        string `json:"bucketName"`
+	InventoryID       string `json:"inventoryID,omitempty"`
+	DestinationBucket string `json:"destinationBucket,omitempty"`
+	Schedule          string `json:"schedule,omitempty"`
+}
+
+// Redact redacts sensitive fields in BucketInventoryAuditDetails
+func (i *BucketInventoryAuditDetails) Redact() {}
+
+// Message returns a human-readable message for bucket inventory audit
+func (i BucketInventoryAuditDetails) Message() string {
+	if i.BucketName != "" && i.InventoryID != "" {
+		return "Bucket inventory '" + i.InventoryID + "' for '" + i.BucketName + "'"
+	}
+	if i.BucketName != "" {
+		return "Bucket inventory for '" + i.BucketName + "'"
+	}
+	return "Bucket inventory modified"
+}
+
+// Details returns specific parameter changes for bucket inventory audit
+func (i BucketInventoryAuditDetails) Details() string {
+	var parts []string
+	if i.DestinationBucket != "" {
+		parts = append(parts, "dest:"+i.DestinationBucket)
+	}
+	if i.Schedule != "" {
+		parts = append(parts, "schedule:"+i.Schedule)
+	}
+	return strings.Join(parts, " ")
+}
+
+// TierAuditDetails captures tier configuration changes
+type TierAuditDetails struct {
+	TierName string `json:"tierName"`
+	TierType string `json:"tierType,omitempty"`
+}
+
+// Redact redacts sensitive fields in TierAuditDetails
+func (t *TierAuditDetails) Redact() {}
+
+// Message returns a human-readable message for tier audit
+func (t TierAuditDetails) Message() string {
+	if t.TierName != "" && t.TierType != "" {
+		return "Tier '" + t.TierName + "' (" + t.TierType + ")"
+	}
+	if t.TierName != "" {
+		return "Tier '" + t.TierName + "'"
+	}
+	return "Tier configuration modified"
+}
+
+// Details returns specific parameter changes for tier audit
+func (t TierAuditDetails) Details() string {
+	return ""
+}
+
+// String returns a simple string representation for Audit (required by eos LogEntry interface)
 func (a Audit) String() string {
-	values := []string{
-		toString("version", a.Version),
-		toTime("time", a.Time),
-		toString("node", a.Node),
-		toString("apiName", a.APIName),
-		toString("category", string(a.Category)),
-		toString("action", string(a.Action)),
-		toString("bucket", a.Bucket),
-		toMap("tags", a.Tags),
-		toString("requestID", a.RequestID),
-		toInterfaceMap("requestClaims", a.ReqClaims),
-		toString("sourceHost", a.SourceHost),
-		toString("accessKey", a.AccessKey),
-		toString("parentUser", a.ParentUser),
-		toInterface("details", a.Details),
-	}
-	values = filterAndSort(values)
-	return strings.Join(values, ",")
+	return fmt.Sprintf("audit: category=%s action=%s api=%s", a.Category, a.Action, a.APIName)
 }
 
 // Message returns a short summary of the config mutation