Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xinput.lib in the MinGW is using DirectX SDK only xinput1_3.dll #28

Open
walbourn opened this issue Nov 27, 2022 · 2 comments
Open

xinput.lib in the MinGW is using DirectX SDK only xinput1_3.dll #28

walbourn opened this issue Nov 27, 2022 · 2 comments

Comments

@walbourn
Copy link

walbourn commented Nov 27, 2022

The xinput library that comes with the MinGW toolset is linking to the XINPUT1_3.DLL. This DLL is only installed by the legacy DirectX End-User Runtime, so it's not present on all machines. Also, this DLL has known security issues.

A better solution is to have libxinput.a link to XINPUT9_1_0.DLL which is present on all Windows machines from Windows Vista forward.

Alternatively, use XINPUT1_4.DLL which is present on Windows 8.0 or later and is also inbox.

@Biswa96
Copy link
Contributor

Biswa96 commented Nov 27, 2022

I think xinput = xinput1_3 was set not to break backward compatibility. If a program need newer version, one can mention -lxinput1_4 explicitly.

The term 'old operating system' varies among users. Last commit was in 2010 mingw-w64/mingw-w64@d3eee29

@walbourn
Copy link
Author

walbourn commented Nov 28, 2022

Ah, I see the various versions now... There should be no need for 1_1 or 1_2 at all.

I'd still recommend making the xinput default be 9.1.0. The only scenario where xinput 1.3 is actually needed is Windows XP.

@walbourn walbourn reopened this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants