test: update repository tests and remove unnecessary comments

zds-s · zds-s · commit 9e011a751780 · 2024-10-23T22:04:02.000+08:00
- Remove empty comment lines from multiple test files
- Update repository class references in UserLoginLog and UserOperationLog tests
- Add @coversNothing annotation to UserRepositoryTest
- Reorder trait usage in PassportLoginRequest
diff --git a/app/Http/Admin/Request/PassportLoginRequest.php b/app/Http/Admin/Request/PassportLoginRequest.php
@@ -25,7 +25,8 @@
 ])]
 class PassportLoginRequest extends FormRequest
 {
-    use ClientIpRequestTrait, ClientOsTrait;
+    use ClientIpRequestTrait;
+    use ClientOsTrait;
 
     public function authorize(): bool
     {
diff --git a/storage/swagger/http.json b/storage/swagger/http.json
diff --git a/tests/Feature/Admin/ControllerCase.php b/tests/Feature/Admin/ControllerCase.php
@@ -20,7 +20,6 @@
 
 /**
  * @internal
- * 
  */
 abstract class ControllerCase extends HttpTestCase
 {
diff --git a/tests/Feature/Admin/DataCenter/AttachmentControllerTest.php b/tests/Feature/Admin/DataCenter/AttachmentControllerTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 final class AttachmentControllerTest extends ControllerCase
 {
diff --git a/tests/Feature/Admin/PassportControllerTest.php b/tests/Feature/Admin/PassportControllerTest.php
@@ -20,7 +20,6 @@
 
 /**
  * @internal
- * 
  */
 final class PassportControllerTest extends HttpTestCase
 {
diff --git a/tests/Feature/Admin/Permission/MenuControllerTest.php b/tests/Feature/Admin/Permission/MenuControllerTest.php
@@ -19,7 +19,6 @@
 
 /**
  * @internal
- * 
  */
 final class MenuControllerTest extends CrudControllerCase
 {
diff --git a/tests/Feature/Admin/Permission/RoleControllerTest.php b/tests/Feature/Admin/Permission/RoleControllerTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 final class RoleControllerTest extends ControllerCase
 {
diff --git a/tests/Feature/Admin/Permission/UserControllerTest.php b/tests/Feature/Admin/Permission/UserControllerTest.php
@@ -24,7 +24,6 @@
 
 /**
  * @internal
- * 
  */
 final class UserControllerTest extends ControllerCase
 {
diff --git a/tests/Feature/Admin/PermissionControllerTest.php b/tests/Feature/Admin/PermissionControllerTest.php
@@ -23,7 +23,6 @@
 
 /**
  * @internal
- * 
  */
 final class PermissionControllerTest extends ControllerCase
 {
diff --git a/tests/Feature/Admin/UserLoginLogControllerTest.php b/tests/Feature/Admin/UserLoginLogControllerTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 final class UserLoginLogControllerTest extends ControllerCase
 {
diff --git a/tests/Feature/Admin/UserOperationLogControllerTest.php b/tests/Feature/Admin/UserOperationLogControllerTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 final class UserOperationLogControllerTest extends ControllerCase
 {
diff --git a/tests/Feature/Casbin/ApiTest.php b/tests/Feature/Casbin/ApiTest.php
@@ -19,7 +19,6 @@
 
 /**
  * @internal
- * 
  */
 final class ApiTest extends TestCase
 {
diff --git a/tests/Feature/Casbin/FactoryTest.php b/tests/Feature/Casbin/FactoryTest.php
@@ -19,7 +19,6 @@
 
 /**
  * @internal
- * 
  */
 final class FactoryTest extends TestCase
 {
diff --git a/tests/Feature/Command/ApplicationInstallCommandTest.php b/tests/Feature/Command/ApplicationInstallCommandTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 #[Group('migrations')]
 final class ApplicationInstallCommandTest extends TestCase
diff --git a/tests/Feature/Repository/AttachmentRepositoryTest.php b/tests/Feature/Repository/AttachmentRepositoryTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 final class AttachmentRepositoryTest extends AbstractTestRepository
 {
diff --git a/tests/Feature/Repository/MenuRepositoryTest.php b/tests/Feature/Repository/MenuRepositoryTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 final class MenuRepositoryTest extends AbstractTestRepository
 {
diff --git a/tests/Feature/Repository/RoleRepositoryTest.php b/tests/Feature/Repository/RoleRepositoryTest.php
@@ -21,7 +21,6 @@
 
 /**
  * @internal
- * 
  */
 final class RoleRepositoryTest extends AbstractTestRepository
 {
diff --git a/tests/Feature/Repository/UserLoginLogRepositoryTest.php b/tests/Feature/Repository/UserLoginLogRepositoryTest.php
@@ -13,14 +13,14 @@
 namespace HyperfTests\Feature\Repository;
 
 use App\Model\UserLoginLog;
+use App\Repository\Logstash\UserLoginLogRepository;
 use Carbon\Carbon;
 use Hyperf\Collection\Collection;
 use Hyperf\DbConnection\Model\Model;
 use Hyperf\Stringable\Str;
 
 /**
  * @internal
- * 
  */
 final class UserLoginLogRepositoryTest extends AbstractTestRepository
 {
@@ -35,7 +35,7 @@ final class UserLoginLogRepositoryTest extends AbstractTestRepository
      * @property Carbon $login_time 登录时间
      * @property string $remark 备注
      */
-    protected string $repositoryClass = \App\Repository\Logstash\UserLoginLogRepository::class;
+    protected string $repositoryClass = UserLoginLogRepository::class;
 
     protected function getAttributes(): array
     {
diff --git a/tests/Feature/Repository/UserOperationLogRepositoryTest.php b/tests/Feature/Repository/UserOperationLogRepositoryTest.php
@@ -13,18 +13,18 @@
 namespace HyperfTests\Feature\Repository;
 
 use App\Model\UserOperationLog;
+use App\Repository\Logstash\UserOperationLogRepository;
 use Faker\Provider\Internet;
 use Hyperf\Collection\Collection;
 use Hyperf\DbConnection\Model\Model;
 use Hyperf\Stringable\Str;
 
 /**
  * @internal
- * 
  */
 final class UserOperationLogRepositoryTest extends AbstractTestRepository
 {
-    protected string $repositoryClass = \App\Repository\Logstash\UserOperationLogRepository::class;
+    protected string $repositoryClass = UserOperationLogRepository::class;
 
     protected function getAttributes(): array
     {
diff --git a/tests/Feature/Repository/UserRepositoryTest.php b/tests/Feature/Repository/UserRepositoryTest.php
@@ -24,6 +24,7 @@
 
 /**
  * @internal
+ * @coversNothing
  */
 final class UserRepositoryTest extends AbstractTestRepository
 {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@`
`25`	`25`	`])]`
`26`	`26`	`class PassportLoginRequest extends FormRequest`
`27`	`27`	`{`
`28`		`- use ClientIpRequestTrait, ClientOsTrait;`
	`28`	`+ use ClientIpRequestTrait;`
	`29`	`+ use ClientOsTrait;`
`29`	`30`
`30`	`31`	`public function authorize(): bool`
`31`	`32`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`
`21`	`21`	`/**`
`22`	`22`	`* @internal`
`23`		`- *`
`24`	`23`	`*/`
`25`	`24`	`abstract class ControllerCase extends HttpTestCase`
`26`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`
`22`	`22`	`/**`
`23`	`23`	`* @internal`
`24`		`- *`
`25`	`24`	`*/`
`26`	`25`	`final class AttachmentControllerTest extends ControllerCase`
`27`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`
`20`	`20`	`/**`
`21`	`21`	`* @internal`
`22`		`- *`
`23`	`22`	`*/`
`24`	`23`	`final class MenuControllerTest extends CrudControllerCase`
`25`	`24`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`
`25`	`25`	`/**`
`26`	`26`	`* @internal`
`27`		`- *`
`28`	`27`	`*/`
`29`	`28`	`final class UserControllerTest extends ControllerCase`
`30`	`29`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`
`24`	`24`	`/**`
`25`	`25`	`* @internal`
`26`		`- *`
`27`	`26`	`*/`
`28`	`27`	`final class PermissionControllerTest extends ControllerCase`
`29`	`28`	`{`