fixed a major bug #issue-2092459591, updated Readme, removed obsolete donation button

minch-dev · minch-dev · commit bbcb0e80fb87 · 2024-01-21T20:29:55.000+03:00
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@ Probably the first and only download manager/accelerator built inside Pale Moon!
 
 `Logo is not ready yet, so there are generic empty arrows in place for now. I can't use the original branded graphics according to the license, so I have to come up with my own before release.`
 
-This fork is a direct continuation of the original XUL-based DownThemAll! extension. It's an update of the last upstream pre-release 3.1.1pre version from 2017. XUL version is unique as it supports setting original file modified dates of downloaded files. I've changed extension id and all settings, so it should work alongside other forks. A few features were added in this version:
+This fork is a direct continuation of the original XUL-based DownThemAll! extension. It's an update of the last upstream pre-release 3.1.1pre version from 2017. Until recently XUL version was unique as it supports setting original file modified dates of downloaded files. I've changed extension id and all settings, so it should work alongside other forks. A few features were added in this version:
 - takes "x-archive-orig-last-modified" http header property of WebArchive.org as file's modification date (or "x-archive-orig-date" / "memento-datetime" when not available)
 - allows to export/import relative local save paths in a download list
 - allows to copy a remote website's directory structure (easier and with more options)
@@ -14,20 +14,22 @@ This fork is a direct continuation of the original XUL-based DownThemAll! extens
 - replaces illegal symbols with their full-width counterparts: 	：＊？＂＜＞｜
 - all of the above works in DTM OneClick mode via the most recent filter used (as expected)
 
-You can run this extension in Pale Moon, Waterfox *Classic*, Basilisk, Firefox ESR 52.x & Firefox Developer Edition 56.x. _Live_ version of Waterfox kinda supports XUL, but not  XPCOM, so of no use for us. SeaMonkey needs some fixes, so maybe [later].
-(Note that WebArchive's search results pages might not work in those Firefox versions though, that's a reoccuring issue with some of the webarchive's libraries, sometimes one of the components breaks the show for the older browsers)
+You can run this extension in Pale Moon, Waterfox *Classic*, Basilisk, Firefox ESR 52.x & Firefox Developer Edition 56.x. Relevant version of Waterfox doesn't support XPCOM, so won't work. SeaMonkey needs some fixes, so maybe later.
 
 Installation
 ==================
 Pale Moon, Waterfox Classic, Basilisk
 -------------------
 
-Simply install .xpi from releases section of this page.
+Simply download and install .xpi file from `releases` section of this page. As with any other extension these methods should work:
+- right click .xpi file and choose `open with` -> [your browser]
+- drag and drop .xpi file into a browser window
+- at the `about:addons` page click ⚙️ -> `install from file`
 
 Firefox ESR 52.x, Firefox Developer Edition 56.x
 -------------------
 
-Open `about:config`, find `xpinstall.signatures.required` and switch it to `false`. Now you can download the .xpi from `releases` section and install it.
+Open `about:config`, find `xpinstall.signatures.required` and switch it to `false`. Now you can install an .xpi file using one of the aforementioned methods.
 
 Firefox 56.x
 -------------------
@@ -37,14 +39,17 @@ If `xpinstall.signatures.required` is not available, one can install an unpacked
 SeaMonkey
 -------------------
 
-Not supported (yet).
+Not supported.
 
 Waterfox
 -------------------
 
-Live version is incompatible, use Waterfox Classic.
+Not supported. Only `Waterfox Classic` works.
 
+Updates
+==================
 
+Update is available as an .xpi file hosted under `latest` release tag at github. You can conviniently smack that `check for updates` button or even turn on an autoupdate.
 
 The legacy text below might still be relevant, although it's not maintaned by me.
 ==================
diff --git a/chrome/content/dtm/manager/manager.js b/chrome/content/dtm/manager/manager.js
@@ -2745,8 +2745,8 @@ var QueueItem = class QueueItem {
 		let rv = Object.create(null);
 		let p = Object.getPrototypeOf(this);
 		for (let u of Dialog_serialize_props) {
-			// only save what is changed
-			if ( !!p[u] && !!this[u] && (p[u] !== this[u])) {
+			// only save what is changed [for some reason these changes break queue saving]
+			if (p[u] !== this[u]) { //if ( !!p[u] && !!this[u] && (p[u] !== this[u])) {
 				rv[u] = this[u];
 			}
 		}
diff --git a/chrome/skin/manager/style.css b/chrome/skin/manager/style.css
@@ -239,6 +239,7 @@ toolbox {
 	-moz-box-pack: center;
 }
 #tooldonate {
+    display:none;
 	list-style-image: url(donate51.png);
 	-moz-image-region: rect(0px,360px,51px,180px);
 	cursor: pointer;
diff --git a/install.rdf b/install.rdf
@@ -5,7 +5,7 @@
 		<em:id>dtm@downthemoon.xul</em:id>
 		<em:name>DownTheMoon!</em:name>
 		<em:description>The mass downloader for Pale Moon.</em:description>
-		<em:version>3.141</em:version>
+		<em:version>3.1415</em:version>
 		<em:bootstrap>true</em:bootstrap>
 		<em:multiprocessCompatible>true</em:multiprocessCompatible>
 		<em:type>2</em:type>
@@ -54,21 +54,36 @@
 		</em:targetApplication-->
 
 		<em:localized><Description><em:description>The mass downloader for Pale Moon.</em:description><em:locale>en-US</em:locale><em:name>DownTheMoon!</em:name><em:translator>The dTm Team</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Der Massen-Download-Manager für Pale Moon</em:description><em:locale>de</em:locale><em:name>DownTheMoon!</em:name><em:translator>Nils Maier</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>El descargador masivo para Pale Moon</em:description><em:locale>es-ES</em:locale><em:name>DownTheMoon!</em:name><em:translator>Urko - Babelzilla.org</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Failide massallalaadija Pale Moonile.</em:description><em:locale>et</em:locale><em:name>DownTheMoon!</em:name><em:translator>Maidur</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>L'extension de téléchargement par lot pour Pale Moon.</em:description><em:locale>fr</em:locale><em:name>DownTheMoon!</em:name><em:translator>L'équipe dTm</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Descargador masivo para Pale Moon.</em:description><em:locale>gl</em:locale><em:name>DownTheMoon!</em:name><em:translator>O equipo de dTm</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Descargador masivo para Pale Moon.</em:description><em:locale>gl-ES</em:locale><em:name>DownTheMoon!</em:name><em:translator>O equipo de dTm</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Lo scaricatore di massa per Pale Moon</em:description><em:locale>it</em:locale><em:name>DownTheMoon!</em:name><em:translator>Il team dTm, Alessandro Menti</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>De bulkdownloader voor Pale Moon.</em:description><em:locale>nl</em:locale><em:name>DownTheMoon!</em:name><em:translator>Het dTm-team</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Menedżer pobierania plików dla Firefoksa.</em:description><em:locale>pl</em:locale><em:name>DownTheMoon!</em:name><em:translator>Leszek(teo)Życzkowski</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>O transferidor em massa para o Pale Moon.</em:description><em:locale>pt-PT</em:locale><em:name>DownTheMoon!</em:name><em:translator>A Equipa dTm</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Менеджер загрузок для Pale Moon.</em:description><em:locale>ru</em:locale><em:name>DownTheMoon!</em:name><em:translator>Sergeys - Russian Mozilla Team</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Množični prenašalnik za Pale Moon.</em:description><em:locale>sl-SI</em:locale><em:name>DownTheMoon!</em:name><em:translator>Ekipa dTm</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Pale Moon için toplu indirme aracı.</em:description><em:locale>tr</em:locale><em:name>DownTheMoon!</em:name><em:translator>S.K.Yerli ve dTm takımı</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Pale Moon 的批量下载工具。</em:description><em:locale>zh-CN</em:locale><em:name>DownTheMoon!</em:name><em:translator>Cye3s &amp; Blacko</em:translator></Description></em:localized>
-		<em:localized><Description><em:description>Pale Moon 的大量下載工具</em:description><em:locale>zh-TW</em:locale><em:name>DownTheMoon!</em:name><em:translator>rayx000, scsi, tiffblue, Sakura3814, Goldie Lin.</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Der Massen-Download-Manager für Pale Moon</em:description><em:locale>de</em:locale><em:name>DownTheMoon!</em:name><em:translator>Nils Maier</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>El descargador masivo para Pale Moon</em:description><em:locale>es-ES</em:locale><em:name>DownTheMoon!</em:name><em:translator>Urko - Babelzilla.org</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Failide massallalaadija Pale Moonile.</em:description><em:locale>et</em:locale><em:name>DownTheMoon!</em:name><em:translator>Maidur</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>L'extension de téléchargement par lot pour Pale Moon.</em:description><em:locale>fr</em:locale><em:name>DownTheMoon!</em:name><em:translator>L'équipe dTm</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Descargador masivo para Pale Moon.</em:description><em:locale>gl</em:locale><em:name>DownTheMoon!</em:name><em:translator>O equipo de dTm</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Descargador masivo para Pale Moon.</em:description><em:locale>gl-ES</em:locale><em:name>DownTheMoon!</em:name><em:translator>O equipo de dTm</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Lo scaricatore di massa per Pale Moon</em:description><em:locale>it</em:locale><em:name>DownTheMoon!</em:name><em:translator>Il team dTm, Alessandro Menti</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>De bulkdownloader voor Pale Moon.</em:description><em:locale>nl</em:locale><em:name>DownTheMoon!</em:name><em:translator>Het dTm-team</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Menedżer pobierania plików dla Firefoksa.</em:description><em:locale>pl</em:locale><em:name>DownTheMoon!</em:name><em:translator>Leszek(teo)Życzkowski</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>O transferidor em massa para o Pale Moon.</em:description><em:locale>pt-PT</em:locale><em:name>DownTheMoon!</em:name><em:translator>A Equipa dTm</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Менеджер загрузок для Pale Moon.</em:description><em:locale>ru</em:locale><em:name>DownTheMoon!</em:name><em:translator>Sergeys - Russian Mozilla Team</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Množični prenašalnik za Pale Moon.</em:description><em:locale>sl-SI</em:locale><em:name>DownTheMoon!</em:name><em:translator>Ekipa dTm</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Pale Moon için toplu indirme aracı.</em:description><em:locale>tr</em:locale><em:name>DownTheMoon!</em:name><em:translator>S.K.Yerli ve dTm takımı</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Pale Moon 的批量下载工具。</em:description><em:locale>zh-CN</em:locale><em:name>DownTheMoon!</em:name><em:translator>Cye3s &amp; Blacko</em:translator></Description></em:localized>
+
+		<em:localized><Description><em:description>Pale Moon 的大量下載工具</em:description><em:locale>zh-TW</em:locale><em:name>DownTheMoon!</em:name><em:translator>rayx000, scsi, tiffblue, Sakura3814, Goldie Lin.</em:translator></Description></em:localized>
 
 	</Description>
 </RDF>
diff --git a/modules/defaultPrefs.js b/modules/defaultPrefs.js
@@ -14,7 +14,7 @@ pref("extensions.dtm.timeout", 300);
 pref("extensions.dtm.maxchunks", 4);
 pref("extensions.dtm.history", 5);
 pref("extensions.dtm.alertbox", 2);
-pref("extensions.dtm.removecompleted", true);
+pref("extensions.dtm.removecompleted", false);
 pref("extensions.dtm.removecanceled", false);
 pref("extensions.dtm.removeaborted", false);
 pref("extensions.dtm.infophrases", true);
diff --git a/update.rdf b/update.rdf
@@ -13,7 +13,7 @@
         <!-- Each RDF:li is a different version of the same add-on -->
         <RDF:li>
           <RDF:Description>
-            <em:version>3.141</em:version> <!-- This is the version number of the add-on -->
+            <em:version>3.1415</em:version> <!-- This is the version number of the add-on -->
 
             <!-- One targetApplication for each application the add-on is compatible with -->
 			<!-- Firefox, Firefox ESR, Firefox DEV Edition, Basilisk, Waterfox Classic -->

Original file line number	Diff line number	Diff line change
`@@ -2745,8 +2745,8 @@ var QueueItem = class QueueItem {`
`2745`	`2745`	`let rv = Object.create(null);`
`2746`	`2746`	`let p = Object.getPrototypeOf(this);`
`2747`	`2747`	`for (let u of Dialog_serialize_props) {`
`2748`		`- // only save what is changed`
`2749`		`- if ( !!p[u] && !!this[u] && (p[u] !== this[u])) {`
	`2748`	`+ // only save what is changed [for some reason these changes break queue saving]`
	`2749`	`+ if (p[u] !== this[u]) { //if ( !!p[u] && !!this[u] && (p[u] !== this[u])) {`
`2750`	`2750`	`rv[u] = this[u];`
`2751`	`2751`	`}`
`2752`	`2752`	`}`
Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,7 @@ toolbox {`
`239`	`239`	`-moz-box-pack: center;`
`240`	`240`	`}`
`241`	`241`	`#tooldonate {`
	`242`	`+ display:none;`
`242`	`243`	`list-style-image: url(donate51.png);`
`243`	`244`	`-moz-image-region: rect(0px,360px,51px,180px);`
`244`	`245`	`cursor: pointer;`