Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on sentry package? #44

Open
grzuy opened this issue Feb 26, 2025 · 0 comments
Open

Remove dependency on sentry package? #44

grzuy opened this issue Feb 26, 2025 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@grzuy
Copy link
Collaborator

grzuy commented Feb 26, 2025

Motivated in part by #39 (comment).

Currently we're calling two function from sentry package.

Would be interesting at least seeing a unfinished draft of some pieces of the implementation needed to replace Sentry.Event.create_event and Sentry.Client.send_event.

First draft doesn't need to have feature parity at all with what currently create_event and send_event have which is feature heavy.

Worth trying something super simple and slim at first:

  • for the create event alternative, an implementation that just barely builds the simplest envelope with just one event payload
  • for the send event alternative, a simple implementation using httpc (similar to other tower reporters, see below) that just sends the payload to sentry using configured DSN

Maybe it's not too much...

What's to gain:

  • Less confusion when configuring :tower_sentry (see Confusion about :tower_sentry vs :sentry config #39)
  • Remove risk of future incompatibility or changes in these sort of "private functions" we're depending on
  • No longer need to test and support multiple version of a dependent package
  • Not depend on an external dependency from which we're using a subset of all it's code.

Test cases should "mostly" continue to be green/pass with the changed/refactored code, as they test the sent payload structure which I guess would be similar.

Other reporter's implementations:

@grzuy grzuy added the help wanted Extra attention is needed label Feb 26, 2025
@grzuy grzuy pinned this issue Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant