Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext match implementation missing #42

Open
miltechniks opened this issue Apr 25, 2023 · 1 comment
Open

ext match implementation missing #42

miltechniks opened this issue Apr 25, 2023 · 1 comment

Comments

@miltechniks
Copy link

First of all thanks for your work.

I tried to attach a gitlab-Server to the LDAP-Wrapper, but there seems to be a missing implementation accordings to the log:
missing-implementation.txt
As Reference also this Pull-Request, which is obsolet with your changes as it doesn't help anymore with version 3.0.1: churchtools#4
As there is the new version, I created here the Issue.

So today I tested it with the version 3.0.1 (commit 94aeab9) and it wasn't successfull.
When I add

ldap.ExtensibleFilter.super_.prototype.matches = function() {
}

it's working, but I'm pretty shure there is some implementation for that function missing. ;-)

@milux
Copy link
Owner

milux commented May 5, 2023

Seems like GitLab is using some sort of unknown special filter, indicated by its OID 1.2.840.113556.1.4.803. According to https://oidref.com/1.2.840.113556.1.4.803, this is a special bitwise matcher.
Your "patch" is obviously not doing anything of that kind, and is also overwriting matches for all instances created from ldap.ExtensibleFilter.super_'s prototype.
Properly fixing PR welcome. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants