Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light - Dark Mode #56

Open
miljkovicjovan opened this issue Nov 4, 2023 · 7 comments · May be fixed by #93
Open

Light - Dark Mode #56

miljkovicjovan opened this issue Nov 4, 2023 · 7 comments · May be fixed by #93
Assignees
Labels
enhancement New feature or request

Comments

@miljkovicjovan
Copy link
Owner

No description provided.

@miljkovicjovan miljkovicjovan added the enhancement New feature or request label Nov 4, 2023
@miljkovicjovan miljkovicjovan self-assigned this Nov 4, 2023
@zablon-oigo
Copy link

Hello, Please Explain more on how you would like this effect i.e. should it be a toggle button or code that detects a user theme automatically?

@miljkovicjovan
Copy link
Owner Author

@zablon-oigo for this issue simply create a setting in settings modal with a toggle which will change a localstorage value to true or false (dark, light). The default option should be light. And then based on that you need to create logic for the styling to change.

@miljkovicjovan miljkovicjovan removed their assignment Nov 24, 2023
@miljkovicjovan miljkovicjovan pinned this issue Nov 24, 2023
@zablon-oigo
Copy link

Please assign me, I can tackle this

@zablon-oigo
Copy link

Hello, I tried running the application locally and I faced an annoying bug, I was wondering if anyone else faced the same issue and how they solved it
react bug

@miljkovicjovan
Copy link
Owner Author

@zablon-oigo please create a separate issue with step by step with how to reproduce

@Lavanya-Sathya Lavanya-Sathya linked a pull request Dec 19, 2023 that will close this issue
@aditya-armal
Copy link

There Should be a option for dark mode to use as per user's system setting. @miljkovicjovan

@miljkovicjovan
Copy link
Owner Author

@aditya-armal yes that would be a nice issue to add once we add the basic toggle switch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants