Safari Light, Safari Dark themes

[vladstudio]

I created two themes that, I think, play nicer with the default MacOS look (I borrowed the colours from Safari with the default accent color).

Safari Dark.json

Safari Light.json

[mikekazakov]

Hey, that looks cool!
What changes did you have to make, comparing to the prebuilt Light and Dark themes?
Would you dare to make a PR that includes them into a default set of themes in NC? :)

[vladstudio]

Thanks!

What changes did you have to make

hmhm well I changed a bunch of colours :-)

Would you dare to make a PR

I can try!

[vladstudio]

@mikekazakov - I cloned the repo and opened it in VSCode but failed to find where the themes are stored. Am I required to use XCode? (Don't use it). If so, I'd ask you to make a PR, never made it either :-)

[mikekazakov]

Default themes are stored in Source/NimbleCommander/NimbleCommander/Resources/Config.json:

nimble-commander/Source/NimbleCommander/NimbleCommander/Resources/Config.json

Line 511 in 73b4daa

"themes_v1": [

I'm pretty sure that nowadays you can fork the repository in GitHub and edit the file directly in the browser without even cloning locally, but that's a matter of preferences of course. Once you commit your changes to the forked repository GitHub will automatically build a new version of NC out of it, the dmg file will be downloadable from the Artifacts section of each integration.

[vladstudio]

whew, I think I created a PR!

[mikekazakov]

I guess this discussion can be closed - thanks for bringing more options to Nimble Commander's appearance!

[mikekazakov]

I'm using the new themes now and noticed that the Dark variant has a white background in the viewer:
"viewerBackgroundColor": "#FFFFFF" - that seems odd. Could you take a look at this color?

[vladstudio]

Oops. Fixed with "viewerBackgroundColor": "#202020"

[mikekazakov]

Great, any PR for that? :)

[vladstudio]

I hope I did it right.

[mikekazakov]

Ah, ok, I pulled that commit into main, thanks!

[mikekazakov]

@vladstudio Themes recently got colours for syntax highlighting, would you like to tune these for Safari Light/Dark?
I've added the same colours as in Light/Dark, but I'm pretty sure they look quite odd in the Safari themes.

[vladstudio]

Hey! I just downloaded the latest version and syntax highlighting does not seem to work for me. All file types use single shade of grey text. Did I miss anything?

Screen.Recording.2024-06-17.at.07.26.39.mp4

[mikekazakov]

I'm gradually adding syntax settings for different languages, so far Bash, C++, JSON and YAML are supported:
https://github.com/mikekazakov/nimble-commander/blob/main/Source/NimbleCommander/NimbleCommander/Resources/SyntaxHighlighting/Main.json
The JSON file should have been highlighted.
Perhaps the build you picked didn't have the color definitions for Safari Light (i.e. it was a previous build) or maybe NC thought that you have a custom version of this theme and didn't load the settings from the version that comes with the app.
Alternatively you can check for errors via Alt+Help->Debug->Show Logs->Viewer->Trace.

[mikekazakov]

Oh, just to clarify, this functionality is available only in nightly builds, not in an "official" release yet.

[vladstudio]

where are nightly builds?

[mikekazakov]

Actions->Nightly Build: https://github.com/mikekazakov/nimble-commander/actions/workflows/nightly.yml
Go to the latest one and click on the "nimble-commander-nightly" artefact at the bottom of the page.