Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PlaneFinder to find planes in complex frames #44

Open
mikeferguson opened this issue Apr 7, 2018 · 2 comments
Open

Allow PlaneFinder to find planes in complex frames #44

mikeferguson opened this issue Apr 7, 2018 · 2 comments

Comments

@mikeferguson
Copy link
Owner

mikeferguson commented Apr 7, 2018

Right now, the plane finder assumes that all visible points, that are within the bounding box, are part of the plane. This works fine for things like "robot views the ground" -- but if anything else enters the frame, it's problematic. It also doesn't let us handle frames with other items/clutter in them, or do more interesting things like find the face plane of the gripper (which has long been something I've wanted to be able to do).

Proposed improvements to PlaneFinder:

  • Actually have it "find planes" by segmenting the image into N planes, each of which are larger than some minimum_points_per_plane (a new parameter).
  • Provide a new set of parameters that allow you to specify reference point & normal vector, in an arbitrary frame, that you would like to find the "closest" plane to. If these parameters are not set, the largest plane will be selected (which is basically backwards compatible with today). For something like "find the ground", you could specify a plane in the base_link. For gripper calibration, you could specify the plane to be nearest the center of the gripper, and provide the normal so we can't pick up the "side" of the gripper.
@mikeferguson
Copy link
Owner Author

A first pass of this is in #109 - where we at least find the plane and only sample from points in that plane - this really only works when > 75-80% of the frame is the plane of interest

@mikeferguson
Copy link
Owner Author

#124 implements the normal vector alignment - although not in an arbitrary frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant