Skip to content

Commit 2ef987e

Browse files
[Chore]Common Logger: Log missing Exception type (microsoft#35084)
log type for exception and inner exception
1 parent 195c6f5 commit 2ef987e

File tree

1 file changed

+23
-8
lines changed

1 file changed

+23
-8
lines changed

src/common/ManagedCommon/Logger.cs

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,29 @@ public static void LogError(string message)
6060

6161
public static void LogError(string message, Exception ex)
6262
{
63-
Log(
64-
message + Environment.NewLine +
65-
ex?.Message + Environment.NewLine +
66-
"Inner exception: " + Environment.NewLine +
67-
ex?.InnerException?.Message + Environment.NewLine +
68-
"Stack trace: " + Environment.NewLine +
69-
ex?.StackTrace,
70-
Error);
63+
if (ex == null)
64+
{
65+
LogError(message);
66+
}
67+
else
68+
{
69+
var exMessage =
70+
message + Environment.NewLine +
71+
ex.GetType() + ": " + ex.Message + Environment.NewLine;
72+
73+
if (ex.InnerException != null)
74+
{
75+
exMessage +=
76+
"Inner exception: " + Environment.NewLine +
77+
ex.InnerException.GetType() + ": " + ex.InnerException.Message + Environment.NewLine;
78+
}
79+
80+
exMessage +=
81+
"Stack trace: " + Environment.NewLine +
82+
ex.StackTrace;
83+
84+
Log(exMessage, Error);
85+
}
7186
}
7287

7388
public static void LogWarning(string message)

0 commit comments

Comments
 (0)