Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling on body element confusing when looking at tests? #43

Open
jgwhite opened this issue Nov 14, 2019 · 0 comments
Open

Styling on body element confusing when looking at tests? #43

jgwhite opened this issue Nov 14, 2019 · 0 comments

Comments

@jgwhite
Copy link
Contributor

jgwhite commented Nov 14, 2019

Because there are some styles on <body> in app/index.html that aren’t (and can’t be) present in tests/index.html we have a mismatch between how the app looks in acceptance tests vs. when it’s running for real:

Screen Shot 2019-11-14 at 12 33 41

We could fix this by moving the containing styles into app/template/application.hbs, i.e.:

<div class="font-sans antialiased h-screen flex">
  {{outlet}}
</div>

This implies also updating the starter HTML and various intermediate steps.

If this change is desirable, let me know and I’ll throw together a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgwhite