Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create embroider branch #39

Open
mike-north opened this issue Jul 23, 2019 · 3 comments
Open

Create embroider branch #39

mike-north opened this issue Jul 23, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mike-north
Copy link
Owner

Stakeholders: @stefanpenner, @ef4, @rwjblue

This is a non-trivial app built exclusively with the "octane programming model", with some reasonable test coverage. It would serve as a good app for testing/benchmarking Embroider, for the purposes of detecting regressions and benchmarking performance.

Action Item: create an embroider branch that uses the embroider build utility.

@mike-north mike-north added enhancement New feature or request help wanted Extra attention is needed labels Jul 23, 2019
@mike-north mike-north self-assigned this Jul 23, 2019
@mike-north
Copy link
Owner Author

Here's the best we can do today

Error: Couldn't find /var/folders/tl/b0xfqc6139g9q5v70dbbwxbh000qqz/T/broccoli-737607DmHTYqQJb3L/out-254-packager_runner_embroider_webpack/package.json. You may need to update your version of ember-cli-fastboot.
    at EmberApp.readPackageJSON (/Users/mnorth/Development/workshops/ember-octane/node_modules/fastboot/src/ember-app.js:350:13)
    at new EmberApp (/Users/mnorth/Development/workshops/ember-octane/node_modules/fastboot/src/ember-app.js:34:23)
    at FastBoot._buildEmberApp (/Users/mnorth/Development/workshops/ember-octane/node_modules/fastboot/src/index.js:114:17)
    at new FastBoot (/Users/mnorth/Development/workshops/ember-octane/node_modules/fastboot/src/index.js:52:10)
    at /Users/mnorth/Development/workshops/ember-octane/node_modules/ember-cli-fastboot/index.js:319:29
    at Layer.handle [as handle_request] (/Users/mnorth/Development/workshops/ember-octane/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/Users/mnorth/Development/workshops/ember-octane/node_modules/express/lib/router/index.js:317:13)
    at /Users/mnorth/Development/workshops/ember-octane/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/Users/mnorth/Development/workshops/ember-octane/node_modules/express/lib/router/index.js:335:12)
    at next (/Users/mnorth/Development/workshops/ember-octane/node_modules/express/lib/router/index.js:275:10)

@mike-north mike-north removed the help wanted Extra attention is needed label Jul 23, 2019
@kiwiupover
Copy link
Collaborator

@dnalagatla I think you might know a bit about this.

@stefanpenner
Copy link

stefanpenner commented Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants