Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG - DashboardView Loads Infinitly #288

Open
mikaelacaron opened this issue Jul 25, 2024 · 2 comments · May be fixed by #300
Open

BUG - DashboardView Loads Infinitly #288

mikaelacaron opened this issue Jul 25, 2024 · 2 comments · May be fixed by #300
Assignees
@UVCoder1002
Labels
bug Something isn't working first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest

Comments

@mikaelacaron
Copy link
Owner

Describe the bug

  • The DashboardView is always in the isLoading state because there is no error handling if the loading fails
  • In DashboardViewModel function getMaintenanceEvents the line let querySnapshot = try? await docRef.getDocuments() doesn't handle any errors and it should

To Reproduce

Steps to reproduce the behavior:

  1. Run the app
  2. The DashboardView loads with a ProgressView

Expected behavior

  • After there is an error show the empty screen, and make isLoading false, so that it isn't infinitely showing a ProgeressView

Screenshots

Device Info (please complete the following information):

  • Device: iPhone 15 Pro Simulator
  • OS: iOS 17.5
  • App Version v1.0(1)

Additional Context

  • Don't make an empty view because that's in a different issue, change isLoading to false`
@mikaelacaron mikaelacaron added bug Something isn't working good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest first-timers-only Issues specifically for people who are new to open source labels Jul 25, 2024
@github-actions github-actions bot mentioned this issue Jul 26, 2024
Closed
@UVCoder1002
Copy link

UVCoder1002 commented Jul 27, 2024 •
edited
Loading

I want to work on this issue.Can I take it up? @mikaelacaron

@mikaelacaron
Copy link
Owner Author

yes! go ahead @UVCoder1002

@UVCoder1002 UVCoder1002 linked a pull request Aug 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UVCoder1002 UVCoder1002

Labels
bug Something isn't working first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest
Projects
Basic Car Maintenance
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: infinite loading on Dashboard UVCoder1002/Basic-Car-Maintenance
2 participants
@mikaelacaron @UVCoder1002