Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average of confidence shuffling #17

Open
honghaoli42 opened this issue Jul 10, 2020 · 0 comments
Open

Average of confidence shuffling #17

honghaoli42 opened this issue Jul 10, 2020 · 0 comments

Comments

@honghaoli42
Copy link
Collaborator

honghaoli42 commented Jul 10, 2020

Original report by Honghao LI (Bitbucket: honghaoli42, ).


Currently the average is implemented as the average over exp(-Ixy), since exponential is convex, it underestimates the shuffled mutual information, leading to fewer cuts. I suggest using the average over Ixy instead, since the intended behavior of shuffled data is zero mutual information, rather than exp(-Ixy) == 1.

https://bitbucket.org/VCabeli/miic_r_package/src/b6a698e3c666c355d6df10c5732b84aab9acc17c/src/confidence_cut.cpp#lines-113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant