Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker updates wrong chapter. #1793

Open
6 tasks done
JDKamalakar opened this issue Feb 28, 2025 · 4 comments · May be fixed by #1795
Open
6 tasks done

Tracker updates wrong chapter. #1793

JDKamalakar opened this issue Feb 28, 2025 · 4 comments · May be fixed by #1795
Labels
Bug Something isn't working

Comments

@JDKamalakar
Copy link

Steps to reproduce

  1. Change tracker's chapter number outside Mihon app.
  2. Mark unread chapter as read / manually read chapter.
  3. Chapter is updated to the chapter.

Expected behavior

  1. Mark the chapter as read.
  2. Check what is the chapter number on the tracker.
  3. If the marked number is higher than the tracker number, then update.
    Eg: On tracker x entry has 24 chapters read & you marked chapter 12 then it should not update the tracker.

Actual behavior

It doesn't check for what is the chapter number on the tracker, it updates it even if the tracker's chapter is higher than the marked chapter.

Crash logs

No response

Mihon version

r7113

Android version

Android 16

Device

Google Pixel 6A

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.17.1.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@JDKamalakar JDKamalakar added the Bug Something isn't working label Feb 28, 2025
@Norsze
Copy link
Contributor

Norsze commented Feb 28, 2025

Congratulations you just described the current actual behaviour. Most likely you have been logged out of one tracker and it fails to update so it writes it out every time as "updated" cause it fails.

@Animeboynz
Copy link
Contributor

Na this is more to do with the "Update trackers when marking chapter as read" I implemented, It doesn't recheck with the trackers to see if the remote has changed since last tracker refresh.

I remember BrutuZ calling me out on this a while back. Ill work on a PR for this now.

@Animeboynz Animeboynz linked a pull request Feb 28, 2025 that will close this issue
@JDKamalakar
Copy link
Author

Congratulations you just described the current actual behaviour. Most likely you have been logged out of one tracker and it fails to update so it writes it out every time as "updated" cause it fails.

Nope I am not logged out but as I use multiple devices let's say eg: on laptop I read till 21 & then come back to the phone & open chapter 16 for bookmarking adding it to history it will directly update the tracker 16 even though it was 21.
But if I open the tracker on Mihon before opening the chapter, this issue won't happen as it will fetch the updated data instead of what is available locally.

@JDKamalakar
Copy link
Author

Thanks bro> Na this is more to do with the "Update trackers when marking chapter as read" I implemented, It doesn't recheck with the trackers to see if the remote has changed since last tracker refresh.

I remember BrutuZ calling me out on this a while back. Ill work on a PR for this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants