Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-language filter for the library #1585

Open
4 tasks done
Lolle2000la opened this issue Dec 17, 2024 · 3 comments
Open
4 tasks done

Per-language filter for the library #1585

Lolle2000la opened this issue Dec 17, 2024 · 3 comments
Labels
Feature request New feature or request

Comments

@Lolle2000la
Copy link

Describe your suggested feature

Currently there is no good way to filter for works in the library in a specific language. Ideally I would want to:

  1. Have a list of languages of which there are currently entries in the library
  2. Be able to filter in or out specific languages, i.e.
    • show only Japanese
    • don't show Japanese and Korean
    • show only Japanese and Korean

It would be nice if it was the same three-state system like with other states like has-unread-chapters etc, where you can either filter in, out or not do any filtering.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.17.1.
  • I will fill out all of the requested information in this form.
@Lolle2000la Lolle2000la added the Feature request New feature or request label Dec 17, 2024
@MajorTanya
Copy link
Contributor

And how would Mihon do this for entries with other values or no specification on what the (original?) language is? Hide them entirely unless this filter is disabled?
Considering the infrequency of sources correctly tagging this information in the first place, I highly doubt there's a good way to do this, if there even is a way in the first place.

@BrutuZ
Copy link

BrutuZ commented Dec 18, 2024

I assumed it would just mimic the extensions language filter in the library, but then you lost me with the tri-state bit

@Lolle2000la
Copy link
Author

Lolle2000la commented Dec 18, 2024

And how would Mihon do this for entries with other values or no specification on what the (original?) language is? Hide them entirely unless this filter is disabled?
Considering the infrequency of sources correctly tagging this information in the first place, I highly doubt there's a good way to do this, if there even is a way in the first place

For one there are already language distinctions in most sources (EN, JP, ALL, etc.) so for the beginning this could only filter entries from sources that themselves filter for certain languages. It musn't be perfect right of the bat to be helpful for speakers of more than one language. Then just allow sources to also save the language for entries in the metadata if that isn't the case already, even when saved via an "ALL" source.

Edit: most sources I'm aware of already take language into account in some shape or form, even obscure ones, offering only one or detecting them correctly when sourced by Mihon.

I assumed it would just mimic the extensions language filter in the library, but then you lost me with the tri-state bit

It would be like most other library filters. Default is no-filtering. Click once and you filter in (only entries with read chapters). Click again and you filter out (don't show entries with read chapters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants