Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale library overlay with grid size #1546

Open
4 tasks done
Kladki opened this issue Dec 5, 2024 · 7 comments
Open
4 tasks done

Scale library overlay with grid size #1546

Kladki opened this issue Dec 5, 2024 · 7 comments
Labels
Feature request New feature or request

Comments

@Kladki
Copy link

Kladki commented Dec 5, 2024

Describe your suggested feature

Currently, no matter the grid size, the overlay (downloaded chapters, unread chapters, local source and language indicators, as well as continue reading button) size is always the same. This looks fine for grid sizes 3-4, but anything lower just makes the overlay disproportionately small for the size of the grid item, and vice-versa for higher grid sizes.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.17.0.
  • I will fill out all of the requested information in this form.
@Kladki Kladki added the Feature request New feature or request label Dec 5, 2024
@MajorTanya
Copy link
Contributor

Can you provide some example screenshots of what you're talking about?

@diegoarff
Copy link

I think they mean that the overlay items don't scale with the grid size, they always stay the same. Examples:

Screenshot_20241205_163004_Mihon
Screenshot_20241205_162843_Mihon

@Kladki
Copy link
Author

Kladki commented Dec 5, 2024 via email

@cuong-tran
Copy link
Contributor

the badges are using Text to display count number. And font size can't be arbitrarily scaled with cover size. Unless there is a way I don't know of, it will require converting those text to image in order to scale it.

@Kladki
Copy link
Author

Kladki commented Dec 6, 2024

Can't some maths just be done against the grid size? For example, assuming that the current scale is ideal for size 3, we can just multiply the font size by 3 (3/1) for size 1, 3/2 for size 2, 3/4 for size 4, etc., rounding if necessary.

@MajorTanya
Copy link
Contributor

Can't some maths just be done against the grid size? For example, assuming that the current scale is ideal for size 3, we can just multiply the font size by 3 (3/1) for size 1, 3/2 for size 2, 3/4 for size 4, etc., rounding if necessary.

Naive approach that wouldn't work on particularly large or small screens.

@Kladki
Copy link
Author

Kladki commented Dec 7, 2024

I mean, you could also scale the initial size based on the screen size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants