Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete after read exclusion categories not respected by manual Delete after Mark as Read #1521

Open
6 tasks done
MajorTanya opened this issue Nov 28, 2024 · 2 comments
Open
6 tasks done
Labels
Bug Something isn't working

Comments

@MajorTanya
Copy link
Contributor

Steps to reproduce

  1. Have an entry in a category
  2. Make sure this category is selected for exclusion in Downloads > Delete chapters > Excluded
  3. Download a chapter in the entry
  4. Mark the chapter as read via the menu, not by opening it and scrolling to the end
  5. Observe the chapter being deleted even though it is in an Excluded category

Expected behavior

Possible & reasonable user expectation: The chapter does not get deleted.

Actual behavior

The chapter is deleted.

Crash logs

No response

Mihon version

0.17.0

Android version

any

Device

any

Other details

It's not clear whether the Excluded categories are supposed to apply to the "After manually marked as read" setting above it. The section structure easily suggests to even an attentive user that these settings are all interconnected.

If the intention is for manual marking to always delete a chapter regardless of exclusions further down, I believe this should be communicated to users in some way, possibly with a text above the setting or by visually separating it from the "After reading automatically delete" setting.

If the intention was for manual marking to respect the excluded categories, this is a bug that should be fixed.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.17.0.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@MajorTanya MajorTanya added the Bug Something isn't working label Nov 28, 2024
@BuckshotRobot
Copy link

I also have this issue on the latest version. Did not have this issue on previous versions. This is definitely a bug, as Delete Chapters > Excluded Categories were respected by "After manually marked as read" setting on previous versions.

Something with the Excluded Categories setting is bugged. If you set a category, leave settings, and return; the setting just shows 'null' instead of the selected category name. If you select three categories, it becomes; 'null, null, null' etc.

@MajorTanya
Copy link
Contributor Author

Something with the Excluded Categories setting is bugged. If you set a category, leave settings, and return; the setting just shows 'null' instead of the selected category name. If you select three categories, it becomes; 'null, null, null' etc.

That is an unrelated problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants