-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to PHP8.1 #76
Conversation
Hey, thank you so much for this PR and sorry for letting you wait this long. Work's been very busy, but I'm getting on it right now :) |
COPY . /dephpend | ||
WORKDIR /dephpend | ||
|
||
RUN curl https://raw.githubusercontent.com/composer/getcomposer.org/76a7060ccb93902cd7576b67264ad91c8a2700e2/web/installer | php -- --quiet \ | ||
&& php -n composer.phar install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are at the place, what do you think, if we replace the installer part with e.G.:
COPY --from=composer:2.4.4 /usr/bin/composer /usr/bin/composer
@mihaeu what is the progress here? |
@mihaeu please? 1.5 years for a PR! |
@mihaeu Necesitas ayuda? Need help? would love to see this get pushed through |
This PR upgrades the entire package and its dependencies to rely on
php 8.1
.The main drive for the php update is to be able to use all latest versions of the existing packages.
Special mention
This specific commit prevents PHP Enum classes from breaking.
It used to break saying that
$node->isAbstract()
doesn't exist forNode\Stmt\Enum_
.This PR includes
$method->getReturnType()->getName()
update.There are some failing tests that I can't make it work with github actions:
json.so
extension: I addedjson
to the list of extensions, but it didn't seem to work.I opened it as a draft to get feedback and assistance before committing to fix the tests. Thanks in advance for this package and for the help!