Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/improve recipe search #13

Open
3 tasks
miguelpduarte opened this issue Feb 6, 2022 · 0 comments
Open
3 tasks

Refactor/improve recipe search #13

miguelpduarte opened this issue Feb 6, 2022 · 0 comments
Labels
better-code Improving code structure or associated tooling improvement An improvement to an already existing feature

Comments

@miguelpduarte
Copy link
Owner

Depends on #5

Improve search by:

  • Making it fully fuzzy (currently it is simply using String.contains?/2 - String.jaro_distance and String.bag_distance had some strange edge cases that made them not be useful for this feature, e.g. not sorting to the top with an exact match)
  • Probably implement the search using the DB instead of filtering in the Elixir code directly
  • Use schemaless changesets to perform parameter filtering and validation

See https://fullstackphoenix.com/tutorials/fuzzy-search-in-phoenix-liveview for some ideas

@miguelpduarte miguelpduarte added improvement An improvement to an already existing feature better-code Improving code structure or associated tooling labels Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-code Improving code structure or associated tooling improvement An improvement to an already existing feature
Projects
None yet
Development

No branches or pull requests

1 participant