Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make running compilation test more robust... #22

Open
mgajda opened this issue Nov 28, 2018 · 5 comments
Open

Make running compilation test more robust... #22

mgajda opened this issue Nov 28, 2018 · 5 comments
Labels
heisenbug Bug appears only in some environments, and steps to replicate it on developer machine are unknown patches-welcome Developers welcome patches or suggestions how it is solved in other libraries.

Comments

@mgajda
Copy link
Collaborator

mgajda commented Nov 28, 2018

json-autotype currently compiles the generated Haskell code immediately after producing it, in order to verify that it indeed can parse all the input files.

We can either bank on the solution that disables this type of testing (which is not the best practice), or fix these weird environments that fail to run it properly.

Currently it fails on:

#patches-accepted

@mgajda mgajda added heisenbug Bug appears only in some environments, and steps to replicate it on developer machine are unknown patches-welcome Developers welcome patches or suggestions how it is solved in other libraries. labels Nov 28, 2018
@workshub
Copy link

workshub bot commented Oct 4, 2019

This issue is now published on WorksHub. If you would like to work on this issue you can
start work on the WorksHub Issue Details page.

@workshub
Copy link

workshub bot commented Dec 13, 2019

A user started working on this issue via WorksHub.

@sigrlami
Copy link
Contributor

@mgajda I think this type of testing should be optional. As generated files in 90% of cases are ADT inside the business application which forces recompilation anyway. But for CI it should be enabled. Thoughts?

@mgajda
Copy link
Collaborator Author

mgajda commented Mar 1, 2020

We can improve error message to make it clear that it may be pure compilation setup flaw.

However, we get more bug reports thanks to this features, which improves the code quality here.

@mgajda
Copy link
Collaborator Author

mgajda commented Mar 1, 2020

We discussed it within xml-typelift project, and we want to make it shared library to make it easier to test freshly generated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
heisenbug Bug appears only in some environments, and steps to replicate it on developer machine are unknown patches-welcome Developers welcome patches or suggestions how it is solved in other libraries.
Projects
None yet
Development

No branches or pull requests

2 participants