chore: appease clippy (#300)

Author: mierak

src/config/address.rs

@@ -172,7 +172,7 @@ mod tests {
         ENV.set("HOME".to_string(), "/home/u123".to_string());
         if let Some(host) = host {
             ENV.set("MPD_HOST".to_string(), host.to_string());
-        };
+        }
         if let Some(port) = port {
             ENV.set("MPD_PORT".to_string(), port.to_string());
         }

src/config/mod.rs

@@ -362,7 +362,7 @@ impl ConfigFile {
         let is_tmux = tmux::is_inside_tmux();
         if is_tmux && !tmux::is_passthrough_enabled()? {
             tmux::enable_passthrough()?;
-        };
+        }
 
         config.album_art.method = match self.image_method.unwrap_or(album_art_method) {
             ImageMethodFile::Iterm2 => ImageMethod::Iterm2,

src/context.rs

@@ -193,7 +193,7 @@ impl AppContext {
 
         if let Ok(Some(lrc)) = self.lrc_index.find_lrc_for_song(song) {
             return Ok(Some(lrc));
-        };
+        }
 
         Ok(None)
     }

src/core/command.rs

@@ -53,7 +53,7 @@ impl Command {
                                 Some(current_id) if current_id > job_id => {
                                     break;
                                 }
-                                Some(_id) => continue,
+                                Some(_id) => {}
                                 None => break,
                             }
                         }

src/core/event_loop.rs

@@ -431,7 +431,7 @@ fn main_task<B: Backend + std::io::Write>(
                 .draw(|frame| {
                     if let Err(err) = ui.render(frame, &mut context) {
                         log::error!(error:? = err; "Failed to render a frame");
-                    };
+                    }
                 })
                 .expect("Expected render to succeed");
 
@@ -491,7 +491,7 @@ fn handle_idle_event(event: IdleEvent, context: &AppContext, result_ui_evs: &mut
         | IdleEvent::Mount => {
             log::warn!(event:?; "Received unhandled event");
         }
-    };
+    }
 
     if let Ok(ev) = event.try_into() {
         result_ui_evs.insert(ev);

src/core/input.rs

@@ -36,7 +36,6 @@ fn input_poll_task(event_tx: &Sender<AppEvent>) {
                 }
                 Err(err) => {
                     log::warn!(error:? = err; "Failed to read input event");
-                    continue;
                 }
             },
             Ok(_) => {}

src/core/scheduler/mod.rs

@@ -115,7 +115,7 @@ where
                         _ => {}
                     },
                     _ => {}
-                };
+                }
 
                 duration =
                     jobs.peek().map(|Reverse(job)| job.run_at().saturating_duration_since(now));
@@ -441,7 +441,7 @@ mod tests {
 
         scheduler.start();
 
-        while results.lock().unwrap().len() < 1 {
+        while results.lock().unwrap().is_empty() {
             std::thread::sleep(Duration::from_millis(10));
         }
         std::thread::sleep(Duration::from_millis(200));

src/core/socket.rs

@@ -16,6 +16,7 @@ use crate::{
         ipc::{SocketCommand, SocketCommandExecute, get_socket_path},
         macros::try_cont,
     },
+    try_skip,
 };
 
 pub(crate) fn init(
@@ -39,7 +40,7 @@ pub(crate) fn init(
                 try_cont!(serde_json::from_str(&buf), "Failed to parse socket command");
 
             log::debug!(command:?, addr:?; "Got command from unix socket");
-            try_cont!(
+            try_skip!(
                 command.execute(&event_tx, &work_tx, &config),
                 "Socket command execution failed"
             );

src/mpd/client.rs

@@ -121,7 +121,7 @@ impl<'name> Client<'name> {
         rx.read_line(&mut buf)?;
         if !buf.starts_with("OK") {
             return Err(MpdError::Generic(format!("Handshake validation failed. '{buf}'")));
-        };
+        }
         let Some(version): Option<Version> =
             buf.strip_prefix("OK MPD ").and_then(|v| v.parse().ok())
         else {
@@ -166,7 +166,7 @@ impl<'name> Client<'name> {
         rx.read_line(&mut buf)?;
         if !buf.starts_with("OK") {
             return Err(MpdError::Generic(format!("Handshake validation failed. '{buf}'")));
-        };
+        }
 
         let Some(version): Option<Version> =
             buf.strip_prefix("OK MPD ").and_then(|v| v.parse().ok())

src/mpd/commands/idle.rs

@@ -45,7 +45,7 @@ impl FromMpd for Vec<IdleEvent> {
             "neighbor" => self.push(IdleEvent::Neighbor),
             "mount" => self.push(IdleEvent::Mount),
             _ => return Ok(LineHandled::No { value }),
-        };
+        }
         Ok(LineHandled::Yes)
     }
 }