Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Get-EntraDirectoryObjectOnPremisesProvisioningError #1305

Merged
merged 7 commits into from
Jan 28, 2025
Merged

fix Get-EntraDirectoryObjectOnPremisesProvisioningError #1305

merged 7 commits into from
Jan 28, 2025

Conversation

KenitoInc
Copy link
Collaborator

@KenitoInc KenitoInc commented Jan 24, 2025 •
edited
Loading

Fixes #1290

@KenitoInc KenitoInc requested a review from a team as a code owner January 24, 2025 09:52
@KenitoInc KenitoInc added Ready For Review The PR Ready for Review P0 Highest priority labels Jan 24, 2025
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit cae9aa2:

✅ Validation status: passed

File Status Preview URL Details
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 4b30190:

✅ Validation status: passed

File Status Preview URL Details
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
test/Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit e56bd71:

✅ Validation status: passed

File Status Preview URL Details
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
test/Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@SteveMutungi254
Copy link
Contributor

@KenitoInc : Added suggestions via this PR - #1308 - based on your branch.

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 918cc9b:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
test/Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded
test/EntraBeta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit c407be6:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
test/Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded
test/EntraBeta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit f4fab6c:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
test/Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded
test/EntraBeta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@SteveMutungi254 SteveMutungi254 linked an issue Jan 27, 2025 that may be closed by this pull request
Get-EntraDirectoryObjectOnPremisesProvisioningError output is very poor and not actionable #1290
Open
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 76e3f50:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
test/Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded
test/EntraBeta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

SteveMutungi254
SteveMutungi254 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteveMutungi254 SteveMutungi254 merged commit c9a5790 into modularize Jan 28, 2025
4 checks passed
KenitoInc added a commit that referenced this pull request Jan 31, 2025
@KenitoInc @SteveMutungi254
fix Get-EntraDirectoryObjectOnPremisesProvisioningError (#1305)
8a5018f 
* fix Get-EntraDirectoryObjectOnPremisesProvisioningError

* Update tests

* Fix tests

* [Enhancements] Get-EntraDirectoryObjectOnPremisesProvisioningError (#1308)

* Add extra lines

* Fix beta mock

* Adding formatting

---------

Co-authored-by: Steve Mutungi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMutungi254 SteveMutungi254 SteveMutungi254 approved these changes

@emmanuel-karanja emmanuel-karanja Awaiting requested review from emmanuel-karanja

@DButoyez DButoyez Awaiting requested review from DButoyez

Assignees
No one assigned
Labels
P0 Highest priority Ready For Review The PR Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-EntraDirectoryObjectOnPremisesProvisioningError output is very poor and not actionable
2 participants
@KenitoInc @SteveMutungi254