-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import changes to TextMate YAML syntax highlighting to fix string literals #79667
Comments
From the other bug:
Looks like we need to think about changing to another grammar. |
Perhaps, but my understanding is that the .tm files from TextMate are converted to JSON. GH is using a different format, sure, but doesn't necessarily indicate you have to use that. |
I tested out https://github.com/atom/language-yaml/blob/master/grammars/yaml.cson and the syntax highlighting we get from that is inferior. We have the latest yaml grammar from textmate/yaml.tmbundle already, so it looks like there is still a need for a fix there for textmate/yaml.tmbundle#26 |
Please take a look at the comment here: textmate/yaml.tmbundle#26 (comment) Seems this is already fixed in TextMate. I wasn't suggesting to use CSON. |
We already have the latest from textmate/yaml.tmbundle |
On VSCode 1.37.1 (f06011a), string literals in YAML aren't treated completely as strings. I opened #54219 a while back but was closed waiting for TextMate to fix this. Based on textmate/yaml.tmbundle#26 it seems that has happened. Can you do an import/conversion and test this?
The text was updated successfully, but these errors were encountered: