Import changes to TextMate YAML syntax highlighting to fix string literals

[heaths]

On VSCode 1.37.1 (f06011a), string literals in YAML aren't treated completely as strings. I opened #54219 a while back but was closed waiting for TextMate to fix this. Based on textmate/yaml.tmbundle#26 it seems that has happened. Can you do an import/conversion and test this?

[alexr00]

From the other bug:

This is already fixed in TextMate (tested in version 2.0-rc.23). Github uses https://github.com/atom/language-yaml/blob/master/grammars/yaml.cson which also works. I don't know if VSCode supports the CSON format but it should be trivially convertible to VSCode-compatible JSON.

Looks like we need to think about changing to another grammar.

[heaths]

Perhaps, but my understanding is that the .tm files from TextMate are converted to JSON. GH is using a different format, sure, but doesn't necessarily indicate you have to use that.

[alexr00]

I tested out https://github.com/atom/language-yaml/blob/master/grammars/yaml.cson and the syntax highlighting we get from that is inferior.

We have the latest yaml grammar from textmate/yaml.tmbundle already, so it looks like there is still a need for a fix there for textmate/yaml.tmbundle#26

[heaths]

Please take a look at the comment here: textmate/yaml.tmbundle#26 (comment)

Seems this is already fixed in TextMate. I wasn't suggesting to use CSON.

[alexr00]

We already have the latest from textmate/yaml.tmbundle