Ruby heredoc in method arguments break braces syntax

[amerov]

• VSCode Version: 1.28.2
  

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Reindent command should not modify HEREDOC (#19227)

[alexr00]

After the heredoc starts, shouldn't it all be heredoc until the ending LOG? In this case the closing parenthesis is highlighted correctly. @rebornix am I understanding this correctly?

[amerov]

@alexr00 It is valid ruby code.
Examples:
https://github.com/rails/rails/blob/master/activemodel/lib/active_model/attributes.rb#L35
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/persistence.rb#L659
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/nested_attributes.rb#L370

[rebornix]

@alexr00 the heredoc content starts from the line following the heredoc identifier (LOG in our case) and we can use the heredoc identifier as a variable in that line, so log(<<-LOG) is a valid function call and <<-LOG is referring to the content after this line (and also ends with LOG). https://docs.ruby-lang.org/en/2.5.0/syntax/literals_rdoc.html

For short, ) is not part of the multiline string, our grammar is kind of wrong.

[alexr00]

Thanks for checking!

[alexr00]

Since this is an issue with the grammar I've moved it to the grammar owners: textmate/ruby.tmbundle#124