Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(low priority) Ruby syntax highlighting issue for regex literals with ! - or + operators #40769

Closed
jeff-hykin opened this issue Dec 24, 2017 · 2 comments
Assignees
Labels
languages-basic Basic language support issues

Comments

@jeff-hykin
Copy link

  • VSCode Version: 1.19
  • OS Version: macOS 10.12.6
  • tested with extensions disabled

Steps to Reproduce:

audience = "world"
thing = ! /hello #{audience}/
puts thing 
#>>> true 

The syntax highlighting for /hello #{audience}/ is screwed up. The problem also exists if the - or + operators are used, however the ~ operator has the correct highlighting.

Solution:

This is a pretty small problem, so mentioning this in the ruby.tmLanguage.json is probably sufficient.

I'm somewhat familiar with language files so I might be able to add a fix and create a pull request in the next few weeks.

@vscodebot vscodebot bot added the languages-basic Basic language support issues label Dec 24, 2017
@aeschli
Copy link
Contributor

aeschli commented Jan 11, 2018

This issue was moved to textmate/ruby.tmbundle#115

@aeschli
Copy link
Contributor

aeschli commented Jan 11, 2018

@jeff-hykin A PR against textmate/ruby.tmbundle#115 would be fantastic!

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

2 participants