"Find in Selection" toggle in text search is broken

[RichardJECooke]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.93.1
• OS Version: Ubuntu 24.0.4.1

Steps to Reproduce:

1. Enter the text below in a new document in VS Code

0000000000000000000000x00000000000000000000
00000000000x000000000000000000x000000000000
00000000000000000000x0000000000000000000000

1. Push ctrl-f (find text)
2. Enter x
3. Enable the "find in selection" filter on the right of the search widget
4. Highlight the first two lines of text

The search results say 1 result found when they should say 3.

Now disable the toggle. The highlighted text disappears! The search box shouldn't make adjustments to the text window.

Highlight all three lines and enable the toggle. Four results are found, which is correct. But highlight the first two lines again and the widget still incorrectly says four results found, not three!

This widget is broken and inconsistent.

[vs-code-engineering]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.96.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[RichardJECooke]

No, I can't upgrade VS Code because your latest version gives me error Missing GLIBC >= 2.28. Thanks though.

Happy coding to you too!

[ArturoDent]

There is, unfortunately, a specific order to using Find in Selection that is not intuituve. See https://stackoverflow.com/a/44339430/836330

1.  Select your line of text
2.  Click the "Find in selection" icon to the right Alt L or ⎇ ⌘ L on macOS)
3.  Enter your find and replace characters in their inputs
4.  Click the Replace/ReplaceAll buttons if desired.

[aidaodedjl]

I've submitted #331038 to fix this. The root cause is inverted comparison logic in FindReplaceState.change()'s searchScope handling (introduced by the multi-selection refactor in b9efdab): a new scope was treated as unchanged whenever any existing range differed from it, so the scope stayed stale after selection changes.