Explorer Find: Support finding folders

[alexandrupetrini]

Type: Bug

Steps to Reproduce:

1. Go to explorer, open search box
   

2. Write search pattern -> get no result.
   

I would rather need to disable this feature until it becomes stable.

Thanks!

VS Code version: Code 1.94.0 (d78a74b, 2024-10-02T13:08:12.626Z)
OS version: Linux x64 6.8.0-45-generic
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-9300HF CPU @ 2.40GHz (8 x 3999)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off webnn: disabled_off
Load (avg)	2, 2, 3
Memory (System)	31.13GB (13.26GB free)
Process Argv	--disable-extensions
Screen Reader	no
VM	0%
DESKTOP_SESSION	undefined
XDG_CURRENT_DESKTOP	undefined
XDG_SESSION_DESKTOP	undefined
XDG_SESSION_TYPE	undefined

Extensions disabled

[gjsjohnmurray]

Does it work better for you if you unchecked the Fuzzy Match button?

[alexandrupetrini]

No, to me it worked better the old way, because it would turn out results, both folders and files (expanded only).
The perfect way would be to return folders and expanded folder files in one go, without having to expand everything.
Would it be nice to keep the previous mode highlight only mode? Yes, it would.

PS: I don't find fuzzy search precise enough, I just selected as it should have found something, imho.

[benibenj]

Very surprised that you are not getting matches in that case.

• Do you ever see results?
• Do you have all files locally? Do you have a special setup?
• Do you possibly exclude this folder/files in the search.exclude setting?

[alexandrupetrini]

Very surprised that you are not getting matches in that case.

• Do you ever see results?
  Yes, but <word>.<word>.<word>. .<ext> are the ones I do not see.
  See bellow.
• Do you have all files locally? Do you have a special setup?
  I am using a Foam (extension) markdown notes setup with a naming convention used in the abandoned Dendron notes extension.
  I think your implementation only allows "." at the end of the file name. It seems new find only works for the 1st folder of a workspace.

Also you don't take into consideration the folder name.
Explorer Find/Filter works well in vscode 1.93.1

• Do you possibly exclude this folder/files in the search.exclude setting?
  I have PeterSchmalfeldt.explorer-exclude extension and search.esclude but they do not impeed 1.93.1 from searching.
  I will investigate furthure.

---

Comming back,

I disabled PeterSchmalfeldt.explorer-exclude and cleaned exclude patterns.
If you open only one folder it would work, but if you use it in a multi-workspace environment it's awful:

Here, I used code --disable-extenions and basically it is only able to find results in the first folder of the workspace and than shows the same results in the other folders.

And again, if I set secnotes folder as primary:

---

And again after I delete (rename) ~/.config/Code to start from scratch:

Find values come from first repo of the workspace only.

[luiul]

I’m experiencing the same issue. The September 2024 update (version 1.94) makes the “Find in Explorer” function less usable, as it now searches only for files rather than both files and folders. I primarily use “Find in Explorer” to search for folders by name, so this change significantly impacts its usability for me. For now, I am reverting to the August 2024 update (version 1.93). @benibenj

[nazar]

Adding comment here that 1.94 "Find in Explorer" seems broken and breaks an important way in which I could find and compare files by highlighted results. The current search either included only matched files or when fuzzy mode is enabled, it sort of highlights but also excludes non matching files. None of these options are currently usable and this seems broken.

Reverting to 1.93.x until this is addressed or we are provided with a switch that enables use to choose between a highlight only or an include only behaviour.

[luiul]

Any updates on this issue? I updated to version 1.95 to try out the new Copilot features, but I may need to revert if this bug hasn’t been fixed. I didn’t see any mention of it in the update notes. It significantly impacts the usefulness of the explorer since I typically use Command + P to find files and Command + Option + F to locate directories (I’ve never found the latter useful for finding files).

I also echo what @nazar says since the fuzzy match toggle controls both the fuzzy match AND the non-matches filter. @benibenj

[gjsjohnmurray]

@luiul this is now available in 1.96 Insiders and will reach the general release (aka Stable) next month.

Insiders can coexist with Stable. You can get it at https://code.visualstudio.com/insiders

[alexandrupetrini]

Hi,
I tested the feature briefly on the insiders and it's very cool.
However, I have one more question: how do we set up shortcuts for the buttons?

[benibenj]

@alexandrupetrini You can set a shortcut for the commands: list.toggleFindMatchType and list.toggleFindMode

[alexandrupetrini]

@alexandrupetrini You can set a shortcut for the commands: list.toggleFindMatchType and list.toggleFindMode

Then I have to say they are not mapped. I noticed this in 1.94.
I just tested my mapping in 1.93 and they work. They don't work in 1.96, you have to click on the buttons to change settings.
If you can confirm it, maybe we should create another issue.

Thanks.

[benibenj]

Thanks for mentioning, should be fixed with this PR: #234193