Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable new minimize/maximize/restore/close buttons due to bug with custom dialogs #159876

Closed
ghost opened this issue Sep 2, 2022 · 4 comments
Closed

Add option to disable new minimize/maximize/restore/close buttons due to bug with custom dialogs #159876

ghost opened this issue Sep 2, 2022 · 4 comments
Assignees
@sbatten
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@ghost
Copy link

ghost commented Sep 2, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.71.0
  • OS Version: Windows 11

Steps to Reproduce:

  1. Enable custom dialogs ("window.dialogStyle": "custom")
  2. Create a new file
  3. Try to close it

image
@gjsjohnmurray
Copy link
Contributor

Please try "window.experimental.windowControlsOverlay.enabled": false (requires VS Code restart)

@ghost
Copy link
Author

ghost commented Sep 2, 2022

Works, thanks! Is it expected to be like this or as a temporary setting?

@IllusionMH IllusionMH mentioned this issue Sep 3, 2022
Closed
@sbatten
Copy link
Member

sbatten commented Oct 17, 2022

@ihor-oleks is this the bug to which you refer? #159671

@sbatten sbatten added the info-needed Issue requires more information from poster label Oct 17, 2022
@ghost
Copy link
Author

ghost commented Oct 18, 2022

@sbatten It seems to be yes

@sbatten sbatten closed this as completed Oct 18, 2022
@sbatten sbatten added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbatten @gjsjohnmurray @vscodenpa